Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: sky/engine/core/css/RuleSet.cpp

Issue 786953008: Remove shadowPseudoElementRules. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/RuleSet.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/RuleSet.cpp
diff --git a/sky/engine/core/css/RuleSet.cpp b/sky/engine/core/css/RuleSet.cpp
index a5e114f2951c8e0c0dd5c2ccf985ba870b378c77..d62931dbc8380aacdbc28fdb6257fd8a6a61d349 100644
--- a/sky/engine/core/css/RuleSet.cpp
+++ b/sky/engine/core/css/RuleSet.cpp
@@ -109,14 +109,6 @@ bool RuleSet::findBestRuleSetAndAdd(const CSSSelector& component, RuleData& rule
addToRuleSet(className, ensurePendingRules()->classRules, ruleData);
return true;
}
- if (!customPseudoElementName.isEmpty()) {
- // Custom pseudos come before ids and classes in the order of tagHistory, and have a relation of
- // ShadowPseudo between them. Therefore we should never be a situation where extractValuesforSelector
- // finsd id and className in addition to custom pseudo.
- ASSERT(id.isEmpty() && className.isEmpty());
- addToRuleSet(customPseudoElementName, ensurePendingRules()->shadowPseudoElementRules, ruleData);
- return true;
- }
if (!tagName.isEmpty()) {
addToRuleSet(tagName, ensurePendingRules()->tagRules, ruleData);
@@ -208,7 +200,6 @@ void RuleSet::compactRules()
compactPendingRules(pendingRules->idRules, m_idRules);
compactPendingRules(pendingRules->classRules, m_classRules);
compactPendingRules(pendingRules->tagRules, m_tagRules);
- compactPendingRules(pendingRules->shadowPseudoElementRules, m_shadowPseudoElementRules);
m_universalRules.shrinkToFit();
m_fontFaceRules.shrinkToFit();
m_keyframesRules.shrinkToFit();
« no previous file with comments | « sky/engine/core/css/RuleSet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698