polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html - Issue 786953007: npm_modules: Fork bower_components into Polymer 0.4.0 and 0.5.0 versions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html

Issue 786953007: npm_modules: Fork bower_components into Polymer 0.4.0 and 0.5.0 versions (Closed) Base URL: https://chromium.googlesource.com/infra/third_party/npm_modules.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-basic.html ('k') | polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning-margin.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html

diff --git a/bower_components/core-overlay/tests/html/core-overlay-positioning.html b/polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html

similarity index 85%

rename from bower_components/core-overlay/tests/html/core-overlay-positioning.html

rename to polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html

index 00813897eaadaa522b152d4f3aad6c1d73f326a2..26b5168336da27423b41693c602cdece445bba2c 100644

--- a/bower_components/core-overlay/tests/html/core-overlay-positioning.html

+++ b/polymer_0.5.0/bower_components/core-overlay/tests/html/core-overlay-positioning.html

@@ -11,7 +11,7 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN

<head>

<title>core-overlay</title>

- <script src="../../../platform/platform.js"></script>

+ <script src="../../../webcomponentsjs/webcomponents.js"></script>

@@ -82,6 +82,21 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN

chai.assert.ok(Math.abs(rect.top - (window.innerHeight - rect.bottom)) < 5, 'overlay centered vertically');

}, next);

+ // does not retain positioning when centered and re-opened

+ function(next) {

+ var listener = function(e) {

+ var dimensions = e.target.dimensions;

+ chai.assert.equal(dimensions.position.h, undefined);

+ chai.assert.equal(dimensions.position.v, undefined);

+ };

+ basic.addEventListener('core-overlay-open-completed', listener, false);

+ testWhenOpen(basic, function() {

+ var rect = basic.getBoundingClientRect();

+ chai.assert.ok(Math.abs(rect.left - (window.innerWidth - rect.right)) < 5, 'overlay centered horizontally');

+ chai.assert.ok(Math.abs(rect.top - (window.innerHeight - rect.bottom)) < 5, 'overlay centered vertically');

+ basic.removeEventListener('core-overlay-open-completed', listener, false);

+ }, next);

+ },

// css positioned overlay

function(next) {

testWhenOpen(overlay, function() {