Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 786953005: add a presubmit check to avoid adding files with windows line endings (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add a presubmit check to avoid adding files with windows line endings BUG=420796, 385395 Committed: https://crrev.com/b639aca53effcba6978bd37c829745b6a84699cf Cr-Commit-Position: refs/heads/master@{#310353}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/windows/Windows/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mostyn Bramley-Moore
@Paweł: PTAL. I'm not sure if there's a better place for such a check. Also, ...
6 years ago (2014-12-22 08:24:30 UTC) #2
tfarina
This seems fine to me, but I'm not well enough familiar with Python to spot ...
6 years ago (2014-12-22 12:13:57 UTC) #4
Mostyn Bramley-Moore
https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py#newcode1620 PRESUBMIT.py:1620: 'these files to contain windows style line endings?\n' + ...
6 years ago (2014-12-22 12:17:32 UTC) #5
Paweł Hajdan Jr.
LGTM
5 years, 11 months ago (2015-01-07 16:41:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786953005/20001
5 years, 11 months ago (2015-01-07 19:14:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 20:31:50 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 20:33:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b639aca53effcba6978bd37c829745b6a84699cf
Cr-Commit-Position: refs/heads/master@{#310353}

Powered by Google App Engine
This is Rietveld 408576698