add a presubmit check to avoid adding files with windows line endings

add a presubmit check to avoid adding files with windows line endings

BUG=420796, 385395
Committed: https://crrev.com/b639aca53effcba6978bd37c829745b6a84699cf
Cr-Commit-Position: refs/heads/master@{#310353}

[Mostyn Bramley-Moore, 2014-12-22 08:24:30]

mostynb@opera.com changed reviewers:
+ dcheng@chromium.org, phajdan.jr@chromium.org, tfarina@chromium.org

[Mostyn Bramley-Moore, 2014-12-22 08:24:30]

@Paweł: PTAL.  I'm not sure if there's a better place for such a check.  

Also, are there any other file types that should be checked for windows line
endings?

[tfarina, 2014-12-22 12:13:57]

tfarina@chromium.org changed reviewers:
- tfarina@chromium.org

[tfarina, 2014-12-22 12:13:57]

This seems fine to me, but I'm not well enough familiar with Python to spot
errors or make suggestions.

Moving myself to CC list.

https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py#newcode1620
PRESUBMIT.py:1620: 'these files to contain windows style line endings?\n' +
s/windows/Windows?

[Mostyn Bramley-Moore, 2014-12-22 12:17:32]

https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/786953005/diff/1/PRESUBMIT.py#newcode1620
PRESUBMIT.py:1620: 'these files to contain windows style line endings?\n' +
On 2014/12/22 12:13:57, tfarina wrote:
> s/windows/Windows?

Done.

[Paweł Hajdan Jr., 2015-01-07 16:41:57]

LGTM

[Mostyn Bramley-Moore, 2015-01-07 19:13:18]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-01-07 19:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786953005/20001

[commit-bot: I haz the power, 2015-01-07 20:31:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-07 20:33:36]

Patchset 2 (id:??) landed as
https://crrev.com/b639aca53effcba6978bd37c829745b6a84699cf
Cr-Commit-Position: refs/heads/master@{#310353}