Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: sky/engine/core/dom/Document.cpp

Issue 786933008: Simplify StyleEngine clean up. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/dom/StyleEngine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Document.cpp
diff --git a/sky/engine/core/dom/Document.cpp b/sky/engine/core/dom/Document.cpp
index d4284fd180d6cb344f903f7bacab537650337b35..8fcd7ddb0e43a7cb9bf24d4ecd76fe194d6aa59a 100644
--- a/sky/engine/core/dom/Document.cpp
+++ b/sky/engine/core/dom/Document.cpp
@@ -331,10 +331,6 @@ Document::~Document()
m_timeline->detachFromDocument();
- // We need to destroy CSSFontSelector before destroying m_fetcher.
- if (m_styleEngine)
- m_styleEngine->detachFromDocument();
-
if (m_elemSheet)
m_elemSheet->clearOwnerNode();
@@ -1283,7 +1279,6 @@ void Document::detach(const AttachContext& context)
m_renderView = 0;
ContainerNode::detach(context);
- m_styleEngine->didDetach();
m_styleEngine = nullptr;
// This is required, as our LocalFrame might delete itself as soon as it detaches
« no previous file with comments | « no previous file | sky/engine/core/dom/StyleEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698