Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 786933008: Simplify StyleEngine clean up. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel1, eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify StyleEngine clean up. The StyleEngine only lives as long as the document is attached, and the document is always detached before it is destroyed. This also means the document for the style engine always has a frame, so we don't need to conditionally create the CSSFontSelector. R=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/69afc61cfd5515ffc991c5cef0ba3a5b93f345be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -40 lines) Patch
M sky/engine/core/dom/Document.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 5 chunks +5 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
6 years ago (2014-12-18 02:44:42 UTC) #2
eseidel1
lgtm I think originally i envisioned StyleEngine being stateless But I suspect it contains document-lifetime ...
6 years ago (2014-12-18 03:36:49 UTC) #4
esprehn
On 2014/12/18 at 03:36:49, eseidel wrote: > lgtm > > I think originally i envisioned ...
6 years ago (2014-12-18 05:37:17 UTC) #5
esprehn
6 years ago (2014-12-18 05:39:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69afc61cfd5515ffc991c5cef0ba3a5b93f345be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698