Make chrome://salsa more like other WebUI code.

chrome/browser/resources/chromeos/salsa.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Redefine '$' here rather than including 'cr.js', since this is
 // the only function needed.  This allows this file to be loaded
 // in a browser directly for layout and some testing purposes.
 var $ = function(id) { return document.getElementById(id); };
 
 var currentTreatment = 0;
@@ skipping 73 matching lines @@
   } else if (e.keyCode == '39' || e.keyCode == '40') {
     selectedTreatment = currentTreatment + 1;
     if (selectedTreatment >= treatments.length)
       selectedTreatment = treatments.length - 1;
   }
 
   if (selectedTreatment != currentTreatment)
     applyTreatment(selectedTreatment);
 }
 
-function applyTreatment(treatment_number) {

[Dan Beam, 2014/12/10 19:19:48]

jsVarsLikeThis

-  if (treatment_number < 0)
-    treatment_number = 0;
-  if (treatment_number >= treatments.length)
-    treatment_number = treatments.length;
+function applyTreatment(treatmentNumber) {
+  if (treatmentNumber < 0)
+    treatmentNumber = 0;
+  if (treatmentNumber >= treatments.length)
+    treatmentNumber = treatments.length;
 
   $('treatment' + currentTreatment).className = 'treatment';
-  currentTreatment = treatment_number;
+  currentTreatment = treatmentNumber;
   $('treatment' + currentTreatment).className = 'selected treatment';
 
-  for (var i = 0; i < treatments[treatment_number].length; i++) {
-    var key = treatments[treatment_number][i].key;
-    var value = treatments[treatment_number][i].value;
+  for (var i = 0; i < treatments[treatmentNumber].length; i++) {
+    var key = treatments[treatmentNumber][i].key;
+    var value = treatments[treatmentNumber][i].value;
     setPreferenceValue(key, value);
   }
 }
 
 function initialize() {
   // Parse the experiment string in the URL.
   treatments = parseURL(document.URL);
 
   // Update the available treatments list.
   for (var i = 0; i < treatments.length; i++) {
     var newTreatment = $('treatment-template').cloneNode(true);
     newTreatment.id = 'treatment' + i.toString();
     newTreatment.removeAttribute('hidden');
     newTreatment.onclick = function() {
       applyTreatment(parseInt(this.textContent));
     };
     newTreatment.textContent = i.toString();
     $('treatment-list').appendChild(newTreatment);
   }
 
   if (treatments.length > 0) {
     // Store a copy of the settings right now so you can reset them afterwards.
     for (var i = 0; i < treatments[0].length; i++)
       backupPreferenceValue(treatments[0][i].key);
 
     // Select Treatment 0 to start
     applyTreatment(0);
   } else {
     // Make the error message visible and hide everything else
-    $('invalid_treatment_info').removeAttribute('hidden');
-    var div = $('valid_treatment_info');
+    $('invalid-treatment-info').hidden = false;

[Dan Beam, 2014/12/10 19:19:48]

we do this a lot more

+    var div = $('valid-treatment-info');
     div.parentNode.removeChild(div);
   }
 }
 
 /**
  * A key handler so the user can use the arrow keys to select their treatments.
  * This should fire any time they press a key
  */
 document.onkeydown = handleKeyPress;
 document.addEventListener('DOMContentLoaded', initialize);