Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 9661001334f919f008cfd384bbacae71d7cc8a0d..2494286031b2a0e78ecc01cdd21ff0759d322df7 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -845,7 +845,7 @@ public class AwContents implements SmartClipProvider,
private void installWebContentsObserver() {
if (mWebContentsObserver != null) {
- mWebContentsObserver.detachFromWebContents();
+ mWebContentsObserver.destroy();
}
mWebContentsObserver = new AwWebContentsObserver(mWebContents, mContentsClient);
}
@@ -956,7 +956,7 @@ public class AwContents implements SmartClipProvider,
if (mCleanupReference != null) {
assert mNativeAwContents != 0;
- mWebContentsObserver.detachFromWebContents();
+ mWebContentsObserver.destroy();
mWebContentsObserver = null;
mContentViewCore.destroy();
mContentViewCore = null;
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698