content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java - Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/web_contents_observer_proxy.cc ('K') | « content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

index 1862e30cdc3a6298b7045a004ac5d5f6ee7afeb5..f2e0262514d3bf02fb0284be0eb83f76cf446feb 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

@@ -4,11 +4,11 @@

package org.chromium.content.browser.test.util;

-import org.chromium.content.browser.WebContentsObserver;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageFinishedHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnReceivedErrorHelper;

import org.chromium.content_public.browser.WebContents;

+import org.chromium.content_public.browser.WebContentsObserver;

/**

* The default WebContentsObserver used by ContentView tests. The below callbacks can be