content/browser/android/browser_jni_registrar.cc - Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/browser_jni_registrar.cc

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java ('k') | content/browser/android/web_contents_observer_android.h » ('j') | content/browser/android/web_contents_observer_proxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/browser_jni_registrar.cc

diff --git a/content/browser/android/browser_jni_registrar.cc b/content/browser/android/browser_jni_registrar.cc

index 02cfceb805e202025572e5466df3cc9cc769dcd3..c6844c19161ef2e86a54d1de56ccec76454b4b24 100644

--- a/content/browser/android/browser_jni_registrar.cc

+++ b/content/browser/android/browser_jni_registrar.cc

@@ -22,7 +22,7 @@

#include "content/browser/android/load_url_params.h"

#include "content/browser/android/popup_touch_handle_drawable.h"

#include "content/browser/android/tracing_controller_android.h"

-#include "content/browser/android/web_contents_observer_android.h"

+#include "content/browser/android/web_contents_observer_proxy.h"

#include "content/browser/device_sensors/sensor_manager_android.h"

#include "content/browser/frame_host/navigation_controller_android.h"

#include "content/browser/gamepad/gamepad_platform_data_fetcher_android.h"

@@ -92,7 +92,7 @@ base::android::RegistrationMethod kContentRegisteredMethods[] = {

content::SyntheticGestureTargetAndroid::RegisterTouchEventSynthesizer},

{"TracingControllerAndroid", content::RegisterTracingControllerAndroid},

{"WebContentsAndroid", content::WebContentsAndroid::Register},

- {"WebContentsObserver", content::RegisterWebContentsObserverAndroid},

+ {"WebContentsObserver", content::RegisterWebContentsObserverProxy},

{"WebViewStatics", content::RegisterWebViewStatics},

};