content/content_jni.gypi - Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_jni.gypi

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/web_contents_observer_android.cc ('K') | « content/browser/android/web_contents_observer_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/content_jni.gypi

diff --git a/content/content_jni.gypi b/content/content_jni.gypi

index a1f098f0f58e8ae23a12c8b220aa7057cefa2f3d..744e9e1884f18a1af8b976995ac21a2f4ec992ef 100644

--- a/content/content_jni.gypi

+++ b/content/content_jni.gypi

@@ -37,9 +37,9 @@

'public/android/java/src/org/chromium/content/browser/TimeZoneMonitor.java',

'public/android/java/src/org/chromium/content/browser/TouchEventSynthesizer.java',

'public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java',

- 'public/android/java/src/org/chromium/content/browser/WebContentsObserver.java',

'public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java',

'public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java',

+ 'public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java',

Yaron 2015/02/25 16:39:33 I assume you have a downstream patch ready for the

jdduke (slow) 2015/02/26 21:22:09 https://chrome-internal-review.googlesource.com/#/

'public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java',

'variables': {