chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java - Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java ('k') | chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java » ('j') | content/browser/android/web_contents_observer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

index 188c41add3f1f68b829dba45112ef995d0e9cc44..bf90c2eaa8c9d8f6ecf00306dae43abb925cacdd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

@@ -37,8 +37,8 @@ import org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizer;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.toolbar.ToolbarModel;

import org.chromium.chrome.browser.ui.toolbar.ToolbarModelSecurityLevel;

-import org.chromium.content.browser.WebContentsObserver;

import org.chromium.content_public.browser.WebContents;

+import org.chromium.content_public.browser.WebContentsObserver;

import org.chromium.ui.base.Clipboard;

import org.chromium.ui.base.DeviceFormFactor;

@@ -273,7 +273,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList

@Override

public void onDismiss(DialogInterface dialog) {

assert mNativeWebsiteSettingsPopup != 0;

- webContentsObserver.detachFromWebContents();

+ webContentsObserver.destroy();

nativeDestroy(mNativeWebsiteSettingsPopup);

}

});