chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 786933005: [Android] Add proxy for Java-based WebContentsObservers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/javatests/src/org/chromium/base/ObserverListTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java » ('j') | content/browser/android/web_contents_observer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 5e399f1c794bd7a4372c8a45e94c4086a0552355..5c4668276c72c3db107fada83c0543299c349701 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -19,7 +19,7 @@ import android.widget.FrameLayout;

import org.chromium.base.CalledByNative;

import org.chromium.base.ObserverList;

-import org.chromium.base.ObserverList.RewindableIterator;

+import org.chromium.base.RewindableIterator;

import org.chromium.base.TraceEvent;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

@@ -47,9 +47,9 @@ import org.chromium.components.navigation_interception.InterceptNavigationDelega

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

-import org.chromium.content.browser.WebContentsObserver;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.WebContents;

+import org.chromium.content_public.browser.WebContentsObserver;

import org.chromium.content_public.common.Referrer;

import org.chromium.content_public.common.TopControlsState;

import org.chromium.printing.PrintManagerDelegateImpl;

@@ -1048,12 +1048,12 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

/**

- * @return An {@link ObserverList.RewindableIterator} instance that points to all of

+ * @return A {@link RewindableIterator} instance that points to all of

* the current {@link TabObserver}s on this class. Note that calling

* {@link java.util.Iterator#remove()} will throw an

* {@link UnsupportedOperationException}.

- protected ObserverList.RewindableIterator<TabObserver> getTabObservers() {

+ protected RewindableIterator<TabObserver> getTabObservers() {

return mObservers.rewindableIterator();

}