Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 786893007: chrome: Rename the remaining entries from "Newtab" to "NewTab". (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rlp+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chrome: Rename the remaining entries from "Newtab" to "NewTab". These entries were found with the following command line: $ git grep Newtab chrome/ BUG=None R=sky@chromium.org Committed: https://crrev.com/38a7cd9b6510c743ed9b9460ffe949c8492cc422 Cr-Commit-Position: refs/heads/master@{#308280}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/extensions/extension_override_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/hotword_helper/manager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years ago (2014-12-10 03:27:42 UTC) #1
sky
LGTM
6 years ago (2014-12-10 15:44:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786893007/20001
6 years ago (2014-12-13 15:57:39 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-13 17:22:50 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-13 17:23:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38a7cd9b6510c743ed9b9460ffe949c8492cc422
Cr-Commit-Position: refs/heads/master@{#308280}

Powered by Google App Engine
This is Rietveld 408576698