Impl-side painting for tables/ layout tests

Impl-side painting for tables/ layout tests

BUG=381919
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187420

[enne (OOO), 2014-12-10 21:16:47]

enne@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2014-12-10 22:22:06]

https://codereview.chromium.org/786893005/diff/60001/LayoutTests/TestExpectat...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/786893005/diff/60001/LayoutTests/TestExpectat...
LayoutTests/TestExpectations:1069: crbug.com/440941 [ Debug ]
tables/mozilla_expected_failures/marvin/backgr_border-table-quirks.html [ Pass
Crash ]
Crashing?

[enne (OOO), 2014-12-10 22:23:09]

https://codereview.chromium.org/786893005/diff/60001/LayoutTests/TestExpectat...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/786893005/diff/60001/LayoutTests/TestExpectat...
LayoutTests/TestExpectations:1069: crbug.com/440941 [ Debug ]
tables/mozilla_expected_failures/marvin/backgr_border-table-quirks.html [ Pass
Crash ]
On 2014/12/10 22:22:06, chrishtr wrote:
> Crashing?

http://crbug.com/440941

[chrishtr, 2014-12-10 22:38:01]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-12-10 22:38:01]

lgtm

[commit-bot: I haz the power, 2014-12-10 22:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/60001

[commit-bot: I haz the power, 2014-12-11 01:50:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 01:50:06]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40762)

[enne (OOO), 2014-12-11 21:54:41]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:08:43]

Failed to apply patch for Tools/Scripts/webkitpy/layout_tests/port/base.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/Scripts/webkitpy/layout_tests/port/base.py
  Hunk #1 FAILED at 1561.
  1 out of 1 hunk FAILED -- saving rejects to file
Tools/Scripts/webkitpy/layout_tests/port/base.py.rej

Patch:       Tools/Scripts/webkitpy/layout_tests/port/base.py
Index: Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py
b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index
de5862c7ce1ecbb54832f4ce5b7acc802a724924..6d38d5b5e9847796b860ee10064de4eafd727a70
100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -1561,6 +1561,7 @@ class Port(object):
             PhysicalTestSuite('editing', ['--enable-impl-side-painting']),
             PhysicalTestSuite('fast', ['--enable-impl-side-painting']),
             PhysicalTestSuite('svg', ['--enable-impl-side-painting']),
+            PhysicalTestSuite('tables', ['--enable-impl-side-painting']),
         ]
 
     def virtual_test_suites(self):

[commit-bot: I haz the power, 2014-12-11 23:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/80001

[commit-bot: I haz the power, 2014-12-11 23:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:09:28]

Failed to apply patch for Tools/Scripts/webkitpy/layout_tests/port/base.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/Scripts/webkitpy/layout_tests/port/base.py
  Hunk #1 FAILED at 1561.
  1 out of 1 hunk FAILED -- saving rejects to file
Tools/Scripts/webkitpy/layout_tests/port/base.py.rej

Patch:       Tools/Scripts/webkitpy/layout_tests/port/base.py
Index: Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py
b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index
de5862c7ce1ecbb54832f4ce5b7acc802a724924..6d38d5b5e9847796b860ee10064de4eafd727a70
100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -1561,6 +1561,7 @@ class Port(object):
             PhysicalTestSuite('editing', ['--enable-impl-side-painting']),
             PhysicalTestSuite('fast', ['--enable-impl-side-painting']),
             PhysicalTestSuite('svg', ['--enable-impl-side-painting']),
+            PhysicalTestSuite('tables', ['--enable-impl-side-painting']),
         ]
 
     def virtual_test_suites(self):

[enne (OOO), 2014-12-11 23:17:17]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:20:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/100001

[commit-bot: I haz the power, 2014-12-12 00:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 00:37:14]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[enne (OOO), 2014-12-12 19:09:05]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-12-12 19:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/100001

[commit-bot: I haz the power, 2014-12-12 22:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:04:49]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/35216)

[enne (OOO), 2014-12-12 23:24:29]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-12-12 23:25:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/100001

[commit-bot: I haz the power, 2014-12-12 23:26:16]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187065

[Noel Gordon, 2014-12-14 06:00:47]

On 2014/12/12 23:26:16, I haz the power (commit-bot) wrote:
> Committed patchset #6 (id:100001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=187065

FYI tables/mozilla_expected_failures/marvin/backgr_position-table-column.html	
results changed too.

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

[lushnikov, 2014-12-15 14:22:41]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/790223003/ by lushnikov@chromium.org.

The reason for reverting is: The patch turned mozilla table tests flaky.

Flakiness dashboard: http://goo.gl/BzGnIn.

[enne (OOO), 2014-12-17 21:13:02]

Flakiness should be fixed by https://codereview.chromium.org/814573003/.  Will
give this another try after that lands.

[enne (OOO), 2014-12-18 00:56:31]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-12-18 00:57:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786893005/120001

[commit-bot: I haz the power, 2014-12-18 02:32:33]

Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187420