Issue 78683002: Let ChangeLog get auto-generated in push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78683002: Let ChangeLog get auto-generated in push-to-trunk script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Let ChangeLog get auto-generated in push-to-trunk script. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17951

Patch Set 2 : Review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -32 lines)			Patch
M	tools/push-to-trunk/common_includes.py	View		1 chunk	+38 lines, -5 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View		2 chunks	+22 lines, -12 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1	5 chunks	+81 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit and a suggestion for a TODO. https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/push_to_trunk.py File tools/push-to-trunk/push_to_trunk.py (right): https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/push_to_trunk.py#newcode155 ...

7 years, 1 month ago (2013-11-21 09:17:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17951.

Expand Messages | Collapse Messages

Issue 78683002: Let ChangeLog get auto-generated in push-to-trunk script. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Review #

Messages