components/password_manager/core/browser/password_manager.cc - Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SupportsWeakPtr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 3b6210033b67b604262eaa40693415bab4a9c34f..d4694cc6e71f15bbb19d203ef398b10e45bf414a 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -157,8 +157,8 @@ void PasswordManager::SetFormHasGeneratedPassword(

// not the common case, and should only happen when there is a bug in our

// ability to detect forms.

bool ssl_valid = form.origin.SchemeIsSecure();

- PasswordFormManager* manager =

- new PasswordFormManager(this, client_, driver, form, ssl_valid);

+ PasswordFormManager* manager = new PasswordFormManager(

+ this, client_, driver->AsWeakPtr(), form, ssl_valid);

pending_login_managers_.push_back(manager);

manager->SetHasGeneratedPassword();

// TODO(gcasto): Add UMA stats to track this.

@@ -442,8 +442,8 @@ void PasswordManager::CreatePendingLoginManagers(

continue; // The current form is already managed.

bool ssl_valid = iter->origin.SchemeIsSecure();

- PasswordFormManager* manager =

- new PasswordFormManager(this, client_, driver, *iter, ssl_valid);

+ PasswordFormManager* manager = new PasswordFormManager(

+ this, client_, driver->AsWeakPtr(), *iter, ssl_valid);

pending_login_managers_.push_back(manager);

PasswordStore::AuthorizationPromptPolicy prompt_policy =