components/password_manager/content/browser/credential_manager_password_form_manager.cc - Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_password_form_manager.cc

Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test compilation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager.gypi ('k') | components/password_manager/core/browser/BUILD.gn » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/content/browser/credential_manager_password_form_manager.cc b/components/password_manager/content/browser/credential_manager_password_form_manager.cc

index 39243eed2756835cd204b7a9184582c330da965d..8906a14c231e34ffd07b761f4c56623f9480a0b3 100644

--- a/components/password_manager/content/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/content/browser/credential_manager_password_form_manager.cc

@@ -20,7 +20,7 @@ CredentialManagerPasswordFormManager::CredentialManagerPasswordFormManager(

ContentCredentialManagerDispatcher* dispatcher)

: PasswordFormManager(driver->GetPasswordManager(),

client,

- driver,

+ driver->GetWeakPtr(),

observed_form,

true),

dispatcher_(dispatcher) {