PasswordFormManager takes WeakPtr<PasswordManagerDriver>

components/password_manager/core/browser/password_manager_driver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
 
 #include <vector>
 
 #include "base/macros.h"
+#include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 
 namespace autofill {
 class AutofillManager;
 struct FormData;
 struct PasswordForm;
 struct PasswordFormFillData;
 }  // namespace autofill
 
 namespace password_manager {
 
 class PasswordAutofillManager;
 class PasswordGenerationManager;
 class PasswordManager;
 
 // Interface that allows PasswordManager core code to interact with its driver
 // (i.e., obtain information from it and give information to it).
 class PasswordManagerDriver {
  public:
-  PasswordManagerDriver() {}
-  virtual ~PasswordManagerDriver() {}
+  PasswordManagerDriver();
+  virtual ~PasswordManagerDriver();
 
   // Fills forms matching |form_data|.
   virtual void FillPasswordForm(
       const autofill::PasswordFormFillData& form_data) = 0;
 
   // Informs the driver that |form| can be used for password generation.
   virtual void AllowPasswordGenerationForForm(
       const autofill::PasswordForm& form) = 0;
 
   // Notifies the driver that account creation |forms| were found.
@@ skipping 14 matching lines @@
 
   // Returns the PasswordGenerationManager associated with this instance.
   virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;
 
   // Returns the PasswordManager associated with this instance.
   virtual PasswordManager* GetPasswordManager() = 0;
 
   // Returns the PasswordAutofillManager associated with this instance.
   virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0;
 
+  // Returns a weak pointer to |this|.
+  base::WeakPtr<PasswordManagerDriver> GetWeakPtr();

[Evan Stade, 2014/12/08 20:02:50]

is there a reason not to use SupportsWeakPtr/AsWeakPtr?

[vabr (Chromium), 2014/12/09 12:55:46]

Done. Thanks for pointing this out.
There is not really a reason against SupportsWeakPtr. The delay between the
driver (members) destruction and the SWP base desctruction (invalidating the
weak pointers) is not important, because both the destruction and potential use
of the driver happen on the UI thread, and thus should not be interleaved.

+
  private:
+  base::WeakPtrFactory<PasswordManagerDriver> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_