Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

Issue 786813004: Generate correct KeyboardCode (VKEY). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x430194-xkb
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/events/events.gyp ('K') | « ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h ('k') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h » ('j') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc
diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc b/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc
index 53a3ce64a7e3c051403c3fbaeda1455adcdab144..a798db61ff034586cc8ff46777ac998ea278d467 100644
--- a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc
+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc
@@ -12,7 +12,7 @@ namespace {
} // anonymous namespace
-DomKey XkbKeySymToDomKey(xkb_keysym_t keysym) {
+DomKey NonPrintableXkbKeySymToDomKey(xkb_keysym_t keysym) {
switch (keysym) {
case XKB_KEY_BackSpace:
return DomKey::BACKSPACE;
@@ -381,7 +381,7 @@ DomKey XkbKeySymToDomKey(xkb_keysym_t keysym) {
}
}
-base::char16 XkbKeySymDeadKey(xkb_keysym_t keysym) {
+base::char16 DeadXkbKeySymToCombiningCharacter(xkb_keysym_t keysym) {
switch (keysym) {
case XKB_KEY_dead_grave:
return 0x0768; // combining grave accent
« ui/events/events.gyp ('K') | « ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h ('k') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h » ('j') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698