Adding a "zone" value to "class LogRecord"

dart/pkg/logging/lib/logging.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  */
 library logging;
 
 import 'dart:async';
 import 'dart:collection';
@@ skipping 119 matching lines @@
   /**
    * Adds a log record for a [message] at a particular [logLevel] if
    * `isLoggable(logLevel)` is true.
    *
    * Use this method to create log entries for user-defined levels. To record a
    * message at a predefined level (e.g. [Level.INFO], [Level.WARNING], etc) you
    * can use their specialized methods instead (e.g. [info], [warning], etc).
    *
    * If [message] is a [Function], it will be lazy evaluated. Additionally, if
    * [message] or its evaluated value is not a [String], then 'toString()' will
    * be called on it and the result will be logged.

[Søren Gjesse, 2014/12/09 07:48:35]

Please update the comment with the information that the current zone is captured
- and maybe what the benefit of that information is.

[kustermann, 2015/01/07 12:38:44]

Done.

    */
   void log(Level logLevel, message, [Object error, StackTrace stackTrace]) {

[Søren Gjesse, 2014/12/09 07:48:35]

Would it make sense to make it possible to override zone here?

[kustermann, 2015/01/07 12:38:44]

Done.

     if (isLoggable(logLevel)) {
       // If message is a Function, evaluate it.
       if (message is Function) message = message();
       // If message is still not a String, call toString().
       if (message is! String) message = message.toString();
 
       var record = new LogRecord(logLevel, message, fullName, error,
-          stackTrace);
+          stackTrace, Zone.current);
 
       if (hierarchicalLoggingEnabled) {
         var target = this;
         while (target != null) {
           target._publish(record);
           target = target.parent;
         }
       } else {
         root._publish(record);
       }
@@ skipping 146 matching lines @@
   final int sequenceNumber;
 
   static int _nextNumber = 0;
 
   /** Associated error (if any) when recording errors messages. */
   final Object error;
 
   /** Associated stackTrace (if any) when recording errors messages. */
   final StackTrace stackTrace;
 
+  /** Zone of the calling code which resulted in this LogRecord. */
+  final Zone zone;
+
   LogRecord(this.level, this.message, this.loggerName, [this.error,

[Søren Gjesse, 2014/12/09 07:48:35]

I know that this is not related to you change, but couldn't this constructor be
private? I don't see any public method for adding a LogRecord.

[kustermann, 2015/01/07 12:38:44]

That would be a breaking change and I don't intent to do this.

And also: It might be useful for others to use it (e.g. modify LogRecords), ...

-                                                        this.stackTrace])
+                                                        this.stackTrace,
+                                                        this.zone])
       : time = new DateTime.now(),
         sequenceNumber = LogRecord._nextNumber++;
 
   String toString() => '[${level.name}] $loggerName: $message';
 }