Source/core/page/CustomContextMenuProvider.cpp - Issue 786753003: Implement type=radio and radiogroup attribute for menuitem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CustomContextMenuProvider.cpp

Issue 786753003: Implement type=radio and radiogroup attribute for menuitem. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebaselined Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/CustomContextMenuProvider.cpp

diff --git a/Source/core/page/CustomContextMenuProvider.cpp b/Source/core/page/CustomContextMenuProvider.cpp

index 0dcb6767c0312aac578c450cc5a7419cffb43cbb..d60fe9ebc9fc5b7b378263303cf794968c2c1629 100644

--- a/Source/core/page/CustomContextMenuProvider.cpp

+++ b/Source/core/page/CustomContextMenuProvider.cpp

@@ -83,7 +83,7 @@ void CustomContextMenuProvider::appendMenuItem(HTMLMenuItemElement* menuItem, Co

bool enabled = !menuItem->fastHasAttribute(disabledAttr);

ContextMenuAction action = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + m_menuItems.size() - 1);

- if (equalIgnoringCase(menuItem->fastGetAttribute(typeAttr), "checkbox"))

+ if (equalIgnoringCase(menuItem->fastGetAttribute(typeAttr), "checkbox") || equalIgnoringCase(menuItem->fastGetAttribute(typeAttr), "radio"))

contextMenu.appendItem(ContextMenuItem(CheckableActionType, action, labelString, enabled, menuItem->fastHasAttribute(checkedAttr)));

else

contextMenu.appendItem(ContextMenuItem(ActionType, action, labelString, enabled, false));

« no previous file with comments | « Source/core/page/ContextMenuControllerTest.cpp ('k') | no next file » | no next file with comments »