LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-click.html - Issue 786753003: Implement type=radio and radiogroup attribute for menuitem.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-click.html

Issue 786753003: Implement type=radio and radiogroup attribute for menuitem. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html ('K') | « LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu-expected.txt ('k') | LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-click-expected.txt » ('j') | Source/core/html/HTMLMenuItemElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script src="../../../resources/js-test.js"></script>	1 <script src="../../../resources/js-test.js"></script>

2 <menu type=popup>	2 <menu type=popup>

3 <menuitem id=mi1 type=checkbox>	3 <menuitem id=mi1 type=checkbox>

	4 <menuitem id=mi2 type=radio radiogroup="group" checked>

	5 <menuitem id=mi3 type=radio radiogroup="group">

	6 <menuitem id=mi4 type=radio radiogroup="group">

4 </menu>	7 </menu>

5 <script>	8 <script>

6	9

7 description('Test that the "checked" attribute of menuitem is toggled with click .');	10 description('Test that the "checked" attribute of menuitem is toggled with click .');

8	11

9 var element = document.getElementById('mi1');	12 var element = document.getElementById('mi1');

10 element.click();	13 element.click();

11 shouldBeTrue('element.hasAttribute("checked")');	14 shouldBeTrue('element.hasAttribute("checked")');

12 element.click();	15 element.click();

13 shouldBeFalse('element.hasAttribute("checked")');	16 shouldBeFalse('element.hasAttribute("checked")');

	17 var mi2 = document.getElementById('mi2');

	18 var mi3 = document.getElementById('mi3');

	19 var mi4 = document.getElementById('mi4');

	20 shouldBeTrue('mi2.hasAttribute("checked")');

	21 mi3.click();

	22 shouldBeFalse('mi2.hasAttribute("checked")');

	23 shouldBeTrue('mi3.hasAttribute("checked")');

	24 mi4.click();

	25 shouldBeFalse('mi3.hasAttribute("checked")');

	26 shouldBeTrue('mi4.hasAttribute("checked")');

14 </script>	27 </script>

OLD	NEW