Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: Source/core/html/HTMLMenuItemElement.cpp

Issue 786753003: Implement type=radio and radiogroup attribute for menuitem. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaselined Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLAttributeNames.in ('k') | Source/core/html/HTMLMenuItemElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/html/HTMLMenuItemElement.h" 6 #include "core/html/HTMLMenuItemElement.h"
7 7
8 #include "core/HTMLNames.h" 8 #include "core/HTMLNames.h"
9 #include "core/dom/ElementTraversal.h"
9 #include "core/events/Event.h" 10 #include "core/events/Event.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 using namespace HTMLNames; 14 using namespace HTMLNames;
14 15
15 inline HTMLMenuItemElement::HTMLMenuItemElement(Document& document) 16 inline HTMLMenuItemElement::HTMLMenuItemElement(Document& document)
16 : HTMLElement(HTMLNames::menuitemTag, document) 17 : HTMLElement(HTMLNames::menuitemTag, document)
17 { 18 {
18 } 19 }
19 20
20 void HTMLMenuItemElement::defaultEventHandler(Event* event) 21 void HTMLMenuItemElement::defaultEventHandler(Event* event)
21 { 22 {
22 if (event->type() == EventTypeNames::click) { 23 if (event->type() == EventTypeNames::click) {
23 if (equalIgnoringCase(fastGetAttribute(typeAttr), "checkbox")) { 24 if (equalIgnoringCase(fastGetAttribute(typeAttr), "checkbox")) {
24 if (fastHasAttribute(checkedAttr)) 25 if (fastHasAttribute(checkedAttr))
25 removeAttribute(checkedAttr); 26 removeAttribute(checkedAttr);
26 else 27 else
27 setAttribute(checkedAttr, "checked"); 28 setAttribute(checkedAttr, "checked");
29 } else if (equalIgnoringCase(fastGetAttribute(typeAttr), "radio")) {
30 if (Element* parent = parentElement()) {
31 const AtomicString& group = fastGetAttribute(radiogroupAttr);
32 for (HTMLMenuItemElement& menuItem : Traversal<HTMLMenuItemEleme nt>::childrenOf(*parent)) {
33 if (!menuItem.fastHasAttribute(checkedAttr))
34 continue;
35 const AtomicString& groupAttr = menuItem.fastGetAttribute(ra diogroupAttr);
36 if (equalIgnoringNullity(groupAttr.impl(), group.impl()))
37 menuItem.removeAttribute(checkedAttr);
38 }
39 }
40 setAttribute(checkedAttr, "checked");
28 } 41 }
29 event->setDefaultHandled(); 42 event->setDefaultHandled();
30 } 43 }
31 } 44 }
32 45
33 DEFINE_NODE_FACTORY(HTMLMenuItemElement) 46 DEFINE_NODE_FACTORY(HTMLMenuItemElement)
34 47
35 } // namespace blink 48 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAttributeNames.in ('k') | Source/core/html/HTMLMenuItemElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698