Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 7867040: Reduce imprecision of incremental marking. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reduce imprecision of incremental marking. Don't mark through caches that will be flushed by MarkCompactPrologue. Make caches sticky grey (don't push them on to the marking stack) to prevent the write-barrier or the marker from marking them. Don't mark through weak links connecting global contexts. Add tests that started failing after merge from the bleeding edge to mjsunit.status and cctests.status. R=erik.corry@gmail.com BUG=v8:1679 Committed: http://code.google.com/p/v8/source/detail?r=9253

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -23 lines) Patch
M src/heap.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/incremental-marking.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/incremental-marking.cc View 8 chunks +85 lines, -18 lines 1 comment Download
M src/mark-compact.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-12 13:51:59 UTC) #1
Erik Corry
9 years, 3 months ago (2011-09-13 07:07:44 UTC) #2
LGTM

http://codereview.chromium.org/7867040/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/7867040/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:683: MarkObjectGrey(ctx->normalized_map_cache());
Perhaps the fact that this routine does not push to the stack should be
reflected in its name.

Powered by Google App Engine
This is Rietveld 408576698