Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 786693002: Move chrome/browser/chromeos/geolocation to chromeos/geolocation (Closed)

Created:
6 years ago by satorux1
Modified:
6 years ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move chrome/browser/chromeos/geolocation to chromeos/geolocation In favor of less things to have in chrome/browser/chromeos. BUG=437691 TEST=everything builds as before Committed: https://crrev.com/de6a5dcfdef67c2ef141db012293b633fc96ae42 Cr-Commit-Position: refs/heads/master@{#308183}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1069 lines) Patch
D chrome/browser/chromeos/geolocation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/geolocation/geoposition.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/chromeos/geolocation/geoposition.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/geolocation/simple_geolocation_provider.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/chromeos/geolocation/simple_geolocation_provider.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/chromeos/geolocation/simple_geolocation_request.h View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/chromeos/geolocation/simple_geolocation_request.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D chrome/browser/chromeos/geolocation/simple_geolocation_unittest.cc View 1 chunk +0 lines, -252 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/timezone/timezone_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/timezone/timezone_request.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/timezone/timezone_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/timezone/timezone_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +7 lines, -0 lines 0 comments Download
A + chromeos/geolocation/DEPS View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A + chromeos/geolocation/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/geolocation/geoposition.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/geolocation/geoposition.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chromeos/geolocation/simple_geolocation_provider.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + chromeos/geolocation/simple_geolocation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/geolocation/simple_geolocation_request.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chromeos/geolocation/simple_geolocation_request.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chromeos/geolocation/simple_geolocation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (10 generated)
satorux1
6 years ago (2014-12-08 06:16:23 UTC) #2
Alexander Alekseev
lgtm
6 years ago (2014-12-08 13:47:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786693002/1
6 years ago (2014-12-08 13:47:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28806)
6 years ago (2014-12-08 13:51:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786693002/40001
6 years ago (2014-12-09 05:35:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29039)
6 years ago (2014-12-09 05:41:04 UTC) #11
satorux1
Got a presubmit error, probably because I forgot to add chromeos/geolocation/DEPS file in the original ...
6 years ago (2014-12-09 07:53:45 UTC) #12
satorux1
+oshima for src/chromeos changes in case alemate is out of town.
6 years ago (2014-12-11 06:54:05 UTC) #14
Alexander Alekseev
On 2014/12/11 06:54:05, satorux1 wrote: > +oshima for src/chromeos changes in case alemate is out ...
6 years ago (2014-12-11 15:25:56 UTC) #15
oshima
thanks, lgtm
6 years ago (2014-12-11 18:10:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786693002/40001
6 years ago (2014-12-12 01:38:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29889)
6 years ago (2014-12-12 01:48:49 UTC) #20
satorux1
+rogerta@. It looks I needed approval from google_apis/OWNERS in order to add +google_apis to src/chromeos/geolocation/DEPS. ...
6 years ago (2014-12-12 03:29:55 UTC) #22
Roger Tawa OOO till Jul 10th
lgtm for DEPS
6 years ago (2014-12-12 16:18:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786693002/40001
6 years ago (2014-12-12 22:14:12 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 22:30:58 UTC) #26
commit-bot: I haz the power
6 years ago (2014-12-12 22:31:47 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de6a5dcfdef67c2ef141db012293b633fc96ae42
Cr-Commit-Position: refs/heads/master@{#308183}

Powered by Google App Engine
This is Rietveld 408576698