Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 7866016: Merge 94832 - Crashes in WebCore::InsertNodeBeforeCommand constructor. (Closed)

Created:
9 years, 1 month ago by sullivan
Modified:
9 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94832 - Crashes in WebCore::InsertNodeBeforeCommand constructor. https://bugs.webkit.org/show_bug.cgi?id=67763 Reviewed by Ryosuke Niwa. Source/WebCore: Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that positions which are before or after a given node cannot return that node as the editable root. Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html * editing/htmlediting.cpp: (WebCore::editableRootForPosition): use containerNode instead of deprecatedNode. LayoutTests: Tests for crash when the selection is outside the contenteditable node. * editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added. * editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added. TBR=sullivan@chromium.org BUG=95550 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
sullivan
9 years, 1 month ago (2011-09-09 22:50:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698