Misc

- Changed regexp logging to include the string being matched and to
  escape commas.
- Fixed issue with block-comparing unaligned strings on arm.
- Added short documentation to one of the Persistent constructors.

[Erik Corry, 2008-10-22 11:44:15]

LGTM

http://codereview.chromium.org/7866/diff/1/4
File src/globals.h (right):

http://codereview.chromium.org/7866/diff/1/4#newcode79
Line 79: 
IA32 is pretty much the only architecture out there that can read unaligned
without a big performance penalty, so perhaps this ifdef should be turned
around.

http://codereview.chromium.org/7866/diff/1/5
File src/log.cc (right):

http://codereview.chromium.org/7866/diff/1/5#newcode365
Line 365: fprintf(logfile_, "%lc", c);
If you want to be able to reconstruct the original strings you should also
escape \ and /.  If this is too annoying considering the high frequency of \ in
regexp source then consider escaping with a different character instead, for
example %.

http://codereview.chromium.org/7866/diff/1/7
File src/objects.cc (right):

http://codereview.chromium.org/7866/diff/1/7#newcode3734
Line 3734: const int kAlignmentMask = sizeof(int) - 1;  // NOLINT
Since you are accessing by uint32_t then that is what you should put in the
sizeof.

http://codereview.chromium.org/7866/diff/1/7#newcode3737
Line 3737: if ((pa_addr & kAlignmentMask) | (pb_addr & kAlignmentMask)) {
!= 0

[Christian Plesner Hansen, 2008-10-22 11:59:02]

http://codereview.chromium.org/7866/diff/1/5
File src/log.cc (right):

http://codereview.chromium.org/7866/diff/1/5#newcode365
Line 365: fprintf(logfile_, "%lc", c);
For now I'm not too worried about automatically reconstructing the original
regexp.