Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: cc/resources/pixel_buffer_raster_worker_pool.cc

Issue 786583002: cc: Renaming Rasterizer and RasterWorkerPool interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/pixel_buffer_raster_worker_pool.h" 5 #include "cc/resources/pixel_buffer_raster_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/containers/stack_container.h" 9 #include "base/containers/stack_container.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 23 matching lines...) Expand all
34 resource_provider_->ReleasePixelBuffer(resource_->id()); 34 resource_provider_->ReleasePixelBuffer(resource_->id());
35 } 35 }
36 36
37 // Overridden from RasterBuffer: 37 // Overridden from RasterBuffer:
38 void Playback(const RasterSource* raster_source, 38 void Playback(const RasterSource* raster_source,
39 const gfx::Rect& rect, 39 const gfx::Rect& rect,
40 float scale) override { 40 float scale) override {
41 if (!memory_) 41 if (!memory_)
42 return; 42 return;
43 43
44 RasterWorkerPool::PlaybackToMemory(memory_, resource_->format(), 44 TileTaskWorkerPool::PlaybackToMemory(memory_, resource_->format(),
45 resource_->size(), stride_, 45 resource_->size(), stride_,
46 raster_source, rect, scale); 46 raster_source, rect, scale);
47 } 47 }
48 48
49 private: 49 private:
50 ResourceProvider* resource_provider_; 50 ResourceProvider* resource_provider_;
51 const Resource* resource_; 51 const Resource* resource_;
52 uint8_t* memory_; 52 uint8_t* memory_;
53 int stride_; 53 int stride_;
54 54
55 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl); 55 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
56 }; 56 };
(...skipping 25 matching lines...) Expand all
82 void RemoveTaskSetsFromTaskCounts(size_t* task_counts, 82 void RemoveTaskSetsFromTaskCounts(size_t* task_counts,
83 const TaskSetCollection& task_sets) { 83 const TaskSetCollection& task_sets) {
84 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) { 84 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
85 if (task_sets[task_set]) 85 if (task_sets[task_set])
86 task_counts[task_set]--; 86 task_counts[task_set]--;
87 } 87 }
88 } 88 }
89 89
90 } // namespace 90 } // namespace
91 91
92 PixelBufferRasterWorkerPool::RasterTaskState::RasterTaskState( 92 PixelBufferTileTaskWorkerPool::RasterTaskState::RasterTaskState(
93 RasterTask* task, 93 RasterTask* task,
94 const TaskSetCollection& task_sets) 94 const TaskSetCollection& task_sets)
95 : type(UNSCHEDULED), task(task), task_sets(task_sets) { 95 : type(UNSCHEDULED), task(task), task_sets(task_sets) {
96 } 96 }
97 97
98 // static 98 // static
99 scoped_ptr<RasterWorkerPool> PixelBufferRasterWorkerPool::Create( 99 scoped_ptr<TileTaskWorkerPool> PixelBufferTileTaskWorkerPool::Create(
100 base::SequencedTaskRunner* task_runner, 100 base::SequencedTaskRunner* task_runner,
101 TaskGraphRunner* task_graph_runner, 101 TaskGraphRunner* task_graph_runner,
102 ContextProvider* context_provider, 102 ContextProvider* context_provider,
103 ResourceProvider* resource_provider, 103 ResourceProvider* resource_provider,
104 size_t max_transfer_buffer_usage_bytes) { 104 size_t max_transfer_buffer_usage_bytes) {
105 return make_scoped_ptr<RasterWorkerPool>( 105 return make_scoped_ptr<TileTaskWorkerPool>(new PixelBufferTileTaskWorkerPool(
106 new PixelBufferRasterWorkerPool(task_runner, 106 task_runner, task_graph_runner, context_provider, resource_provider,
107 task_graph_runner, 107 max_transfer_buffer_usage_bytes));
108 context_provider,
109 resource_provider,
110 max_transfer_buffer_usage_bytes));
111 } 108 }
112 109
113 PixelBufferRasterWorkerPool::PixelBufferRasterWorkerPool( 110 PixelBufferTileTaskWorkerPool::PixelBufferTileTaskWorkerPool(
114 base::SequencedTaskRunner* task_runner, 111 base::SequencedTaskRunner* task_runner,
115 TaskGraphRunner* task_graph_runner, 112 TaskGraphRunner* task_graph_runner,
116 ContextProvider* context_provider, 113 ContextProvider* context_provider,
117 ResourceProvider* resource_provider, 114 ResourceProvider* resource_provider,
118 size_t max_transfer_buffer_usage_bytes) 115 size_t max_transfer_buffer_usage_bytes)
119 : task_runner_(task_runner), 116 : task_runner_(task_runner),
120 task_graph_runner_(task_graph_runner), 117 task_graph_runner_(task_graph_runner),
121 namespace_token_(task_graph_runner->GetNamespaceToken()), 118 namespace_token_(task_graph_runner->GetNamespaceToken()),
122 context_provider_(context_provider), 119 context_provider_(context_provider),
123 resource_provider_(resource_provider), 120 resource_provider_(resource_provider),
124 shutdown_(false), 121 shutdown_(false),
125 scheduled_raster_task_count_(0u), 122 scheduled_raster_task_count_(0u),
126 bytes_pending_upload_(0u), 123 bytes_pending_upload_(0u),
127 max_bytes_pending_upload_(max_transfer_buffer_usage_bytes), 124 max_bytes_pending_upload_(max_transfer_buffer_usage_bytes),
128 has_performed_uploads_since_last_flush_(false), 125 has_performed_uploads_since_last_flush_(false),
129 check_for_completed_raster_task_notifier_( 126 check_for_completed_raster_task_notifier_(
130 task_runner, 127 task_runner,
131 base::Bind(&PixelBufferRasterWorkerPool::CheckForCompletedRasterTasks, 128 base::Bind(
132 base::Unretained(this)), 129 &PixelBufferTileTaskWorkerPool::CheckForCompletedRasterTasks,
130 base::Unretained(this)),
133 base::TimeDelta::FromMilliseconds( 131 base::TimeDelta::FromMilliseconds(
134 kCheckForCompletedRasterTasksDelayMs)), 132 kCheckForCompletedRasterTasksDelayMs)),
135 raster_finished_weak_ptr_factory_(this) { 133 task_set_finished_weak_ptr_factory_(this) {
136 DCHECK(context_provider_); 134 DCHECK(context_provider_);
137 std::fill(task_counts_, task_counts_ + kNumberOfTaskSets, 0); 135 std::fill(task_counts_, task_counts_ + kNumberOfTaskSets, 0);
138 } 136 }
139 137
140 PixelBufferRasterWorkerPool::~PixelBufferRasterWorkerPool() { 138 PixelBufferTileTaskWorkerPool::~PixelBufferTileTaskWorkerPool() {
141 DCHECK_EQ(0u, raster_task_states_.size()); 139 DCHECK_EQ(0u, raster_task_states_.size());
142 DCHECK_EQ(0u, raster_tasks_with_pending_upload_.size()); 140 DCHECK_EQ(0u, raster_tasks_with_pending_upload_.size());
143 DCHECK_EQ(0u, completed_raster_tasks_.size()); 141 DCHECK_EQ(0u, completed_raster_tasks_.size());
144 DCHECK_EQ(0u, completed_image_decode_tasks_.size()); 142 DCHECK_EQ(0u, completed_image_decode_tasks_.size());
145 DCHECK(NonEmptyTaskSetsFromTaskCounts(task_counts_).none()); 143 DCHECK(NonEmptyTaskSetsFromTaskCounts(task_counts_).none());
146 } 144 }
147 145
148 Rasterizer* PixelBufferRasterWorkerPool::AsRasterizer() { return this; } 146 TileTaskRunner* PixelBufferTileTaskWorkerPool::AsTileTaskRunner() {
147 return this;
148 }
149 149
150 void PixelBufferRasterWorkerPool::SetClient(RasterizerClient* client) { 150 void PixelBufferTileTaskWorkerPool::SetClient(TileTaskRunnerClient* client) {
151 client_ = client; 151 client_ = client;
152 } 152 }
153 153
154 void PixelBufferRasterWorkerPool::Shutdown() { 154 void PixelBufferTileTaskWorkerPool::Shutdown() {
155 TRACE_EVENT0("cc", "PixelBufferRasterWorkerPool::Shutdown"); 155 TRACE_EVENT0("cc", "PixelBufferTileTaskWorkerPool::Shutdown");
156 156
157 shutdown_ = true; 157 shutdown_ = true;
158 158
159 TaskGraph empty; 159 TaskGraph empty;
160 task_graph_runner_->ScheduleTasks(namespace_token_, &empty); 160 task_graph_runner_->ScheduleTasks(namespace_token_, &empty);
161 task_graph_runner_->WaitForTasksToFinishRunning(namespace_token_); 161 task_graph_runner_->WaitForTasksToFinishRunning(namespace_token_);
162 162
163 CheckForCompletedRasterizerTasks(); 163 CheckForCompletedRasterizerTasks();
164 CheckForCompletedUploads(); 164 CheckForCompletedUploads();
165 165
166 check_for_completed_raster_task_notifier_.Shutdown(); 166 check_for_completed_raster_task_notifier_.Shutdown();
167 167
168 for (RasterTaskState::Vector::iterator it = raster_task_states_.begin(); 168 for (RasterTaskState::Vector::iterator it = raster_task_states_.begin();
169 it != raster_task_states_.end(); 169 it != raster_task_states_.end();
170 ++it) { 170 ++it) {
171 RasterTaskState& state = *it; 171 RasterTaskState& state = *it;
172 172
173 // All unscheduled tasks need to be canceled. 173 // All unscheduled tasks need to be canceled.
174 if (state.type == RasterTaskState::UNSCHEDULED) { 174 if (state.type == RasterTaskState::UNSCHEDULED) {
175 completed_raster_tasks_.push_back(state.task); 175 completed_raster_tasks_.push_back(state.task);
176 state.type = RasterTaskState::COMPLETED; 176 state.type = RasterTaskState::COMPLETED;
177 } 177 }
178 } 178 }
179 DCHECK_EQ(completed_raster_tasks_.size(), raster_task_states_.size()); 179 DCHECK_EQ(completed_raster_tasks_.size(), raster_task_states_.size());
180 } 180 }
181 181
182 void PixelBufferRasterWorkerPool::ScheduleTasks(RasterTaskQueue* queue) { 182 void PixelBufferTileTaskWorkerPool::ScheduleTasks(TileTaskQueue* queue) {
183 TRACE_EVENT0("cc", "PixelBufferRasterWorkerPool::ScheduleTasks"); 183 TRACE_EVENT0("cc", "PixelBufferTileTaskWorkerPool::ScheduleTasks");
184 184
185 if (should_notify_client_if_no_tasks_are_pending_.none()) 185 if (should_notify_client_if_no_tasks_are_pending_.none())
186 TRACE_EVENT_ASYNC_BEGIN0("cc", "ScheduledTasks", this); 186 TRACE_EVENT_ASYNC_BEGIN0("cc", "ScheduledTasks", this);
187 187
188 should_notify_client_if_no_tasks_are_pending_.set(); 188 should_notify_client_if_no_tasks_are_pending_.set();
189 std::fill(task_counts_, task_counts_ + kNumberOfTaskSets, 0); 189 std::fill(task_counts_, task_counts_ + kNumberOfTaskSets, 0);
190 190
191 // Update raster task state and remove items from old queue. 191 // Update raster task state and remove items from old queue.
192 for (RasterTaskQueue::Item::Vector::const_iterator it = queue->items.begin(); 192 for (TileTaskQueue::Item::Vector::const_iterator it = queue->items.begin();
193 it != queue->items.end(); 193 it != queue->items.end(); ++it) {
194 ++it) { 194 const TileTaskQueue::Item& item = *it;
195 const RasterTaskQueue::Item& item = *it;
196 RasterTask* task = item.task; 195 RasterTask* task = item.task;
197 196
198 // Remove any old items that are associated with this task. The result is 197 // Remove any old items that are associated with this task. The result is
199 // that the old queue is left with all items not present in this queue, 198 // that the old queue is left with all items not present in this queue,
200 // which we use below to determine what tasks need to be canceled. 199 // which we use below to determine what tasks need to be canceled.
201 RasterTaskQueue::Item::Vector::iterator old_it = 200 TileTaskQueue::Item::Vector::iterator old_it =
202 std::find_if(raster_tasks_.items.begin(), 201 std::find_if(raster_tasks_.items.begin(), raster_tasks_.items.end(),
203 raster_tasks_.items.end(), 202 TileTaskQueue::Item::TaskComparator(task));
204 RasterTaskQueue::Item::TaskComparator(task));
205 if (old_it != raster_tasks_.items.end()) { 203 if (old_it != raster_tasks_.items.end()) {
206 std::swap(*old_it, raster_tasks_.items.back()); 204 std::swap(*old_it, raster_tasks_.items.back());
207 raster_tasks_.items.pop_back(); 205 raster_tasks_.items.pop_back();
208 } 206 }
209 207
210 RasterTaskState::Vector::iterator state_it = 208 RasterTaskState::Vector::iterator state_it =
211 std::find_if(raster_task_states_.begin(), 209 std::find_if(raster_task_states_.begin(),
212 raster_task_states_.end(), 210 raster_task_states_.end(),
213 RasterTaskState::TaskComparator(task)); 211 RasterTaskState::TaskComparator(task));
214 if (state_it != raster_task_states_.end()) { 212 if (state_it != raster_task_states_.end()) {
215 RasterTaskState& state = *state_it; 213 RasterTaskState& state = *state_it;
216 214
217 state.task_sets = item.task_sets; 215 state.task_sets = item.task_sets;
218 // |raster_tasks_required_for_activation_count| accounts for all tasks 216 // |raster_tasks_required_for_activation_count| accounts for all tasks
219 // that need to complete before we can send a "ready to activate" signal. 217 // that need to complete before we can send a "ready to activate" signal.
220 // Tasks that have already completed should not be part of this count. 218 // Tasks that have already completed should not be part of this count.
221 if (state.type != RasterTaskState::COMPLETED) 219 if (state.type != RasterTaskState::COMPLETED)
222 AddTaskSetsToTaskCounts(task_counts_, item.task_sets); 220 AddTaskSetsToTaskCounts(task_counts_, item.task_sets);
223 221
224 continue; 222 continue;
225 } 223 }
226 224
227 DCHECK(!task->HasBeenScheduled()); 225 DCHECK(!task->HasBeenScheduled());
228 raster_task_states_.push_back(RasterTaskState(task, item.task_sets)); 226 raster_task_states_.push_back(RasterTaskState(task, item.task_sets));
229 AddTaskSetsToTaskCounts(task_counts_, item.task_sets); 227 AddTaskSetsToTaskCounts(task_counts_, item.task_sets);
230 } 228 }
231 229
232 // Determine what tasks in old queue need to be canceled. 230 // Determine what tasks in old queue need to be canceled.
233 for (RasterTaskQueue::Item::Vector::const_iterator it = 231 for (TileTaskQueue::Item::Vector::const_iterator it =
234 raster_tasks_.items.begin(); 232 raster_tasks_.items.begin();
235 it != raster_tasks_.items.end(); 233 it != raster_tasks_.items.end(); ++it) {
236 ++it) { 234 const TileTaskQueue::Item& item = *it;
237 const RasterTaskQueue::Item& item = *it;
238 RasterTask* task = item.task; 235 RasterTask* task = item.task;
239 236
240 RasterTaskState::Vector::iterator state_it = 237 RasterTaskState::Vector::iterator state_it =
241 std::find_if(raster_task_states_.begin(), 238 std::find_if(raster_task_states_.begin(),
242 raster_task_states_.end(), 239 raster_task_states_.end(),
243 RasterTaskState::TaskComparator(task)); 240 RasterTaskState::TaskComparator(task));
244 // We've already processed completion if we can't find a RasterTaskState for 241 // We've already processed completion if we can't find a RasterTaskState for
245 // this task. 242 // this task.
246 if (state_it == raster_task_states_.end()) 243 if (state_it == raster_task_states_.end())
247 continue; 244 continue;
(...skipping 26 matching lines...) Expand all
274 // Schedule new tasks. 271 // Schedule new tasks.
275 ScheduleMoreTasks(); 272 ScheduleMoreTasks();
276 273
277 // Reschedule check for completed raster tasks. 274 // Reschedule check for completed raster tasks.
278 check_for_completed_raster_task_notifier_.Schedule(); 275 check_for_completed_raster_task_notifier_.Schedule();
279 276
280 TRACE_EVENT_ASYNC_STEP_INTO1( 277 TRACE_EVENT_ASYNC_STEP_INTO1(
281 "cc", "ScheduledTasks", this, StateName(), "state", StateAsValue()); 278 "cc", "ScheduledTasks", this, StateName(), "state", StateAsValue());
282 } 279 }
283 280
284 void PixelBufferRasterWorkerPool::CheckForCompletedTasks() { 281 void PixelBufferTileTaskWorkerPool::CheckForCompletedTasks() {
285 TRACE_EVENT0("cc", "PixelBufferRasterWorkerPool::CheckForCompletedTasks"); 282 TRACE_EVENT0("cc", "PixelBufferTileTaskWorkerPool::CheckForCompletedTasks");
286 283
287 CheckForCompletedRasterizerTasks(); 284 CheckForCompletedRasterizerTasks();
288 CheckForCompletedUploads(); 285 CheckForCompletedUploads();
289 FlushUploads(); 286 FlushUploads();
290 287
291 for (RasterizerTask::Vector::const_iterator it = 288 for (TileTask::Vector::const_iterator it =
292 completed_image_decode_tasks_.begin(); 289 completed_image_decode_tasks_.begin();
293 it != completed_image_decode_tasks_.end(); 290 it != completed_image_decode_tasks_.end(); ++it) {
294 ++it) { 291 TileTask* task = it->get();
295 RasterizerTask* task = it->get();
296 task->RunReplyOnOriginThread(); 292 task->RunReplyOnOriginThread();
297 } 293 }
298 completed_image_decode_tasks_.clear(); 294 completed_image_decode_tasks_.clear();
299 295
300 for (RasterTask::Vector::const_iterator it = completed_raster_tasks_.begin(); 296 for (RasterTask::Vector::const_iterator it = completed_raster_tasks_.begin();
301 it != completed_raster_tasks_.end(); 297 it != completed_raster_tasks_.end();
302 ++it) { 298 ++it) {
303 RasterTask* task = it->get(); 299 RasterTask* task = it->get();
304 RasterTaskState::Vector::iterator state_it = 300 RasterTaskState::Vector::iterator state_it =
305 std::find_if(raster_task_states_.begin(), 301 std::find_if(raster_task_states_.begin(),
306 raster_task_states_.end(), 302 raster_task_states_.end(),
307 RasterTaskState::TaskComparator(task)); 303 RasterTaskState::TaskComparator(task));
308 DCHECK(state_it != raster_task_states_.end()); 304 DCHECK(state_it != raster_task_states_.end());
309 DCHECK_EQ(RasterTaskState::COMPLETED, state_it->type); 305 DCHECK_EQ(RasterTaskState::COMPLETED, state_it->type);
310 306
311 std::swap(*state_it, raster_task_states_.back()); 307 std::swap(*state_it, raster_task_states_.back());
312 raster_task_states_.pop_back(); 308 raster_task_states_.pop_back();
313 309
314 task->RunReplyOnOriginThread(); 310 task->RunReplyOnOriginThread();
315 } 311 }
316 completed_raster_tasks_.clear(); 312 completed_raster_tasks_.clear();
317 } 313 }
318 314
319 scoped_ptr<RasterBuffer> PixelBufferRasterWorkerPool::AcquireBufferForRaster( 315 scoped_ptr<RasterBuffer> PixelBufferTileTaskWorkerPool::AcquireBufferForRaster(
320 const Resource* resource) { 316 const Resource* resource) {
321 return make_scoped_ptr<RasterBuffer>( 317 return make_scoped_ptr<RasterBuffer>(
322 new RasterBufferImpl(resource_provider_, resource)); 318 new RasterBufferImpl(resource_provider_, resource));
323 } 319 }
324 320
325 void PixelBufferRasterWorkerPool::ReleaseBufferForRaster( 321 void PixelBufferTileTaskWorkerPool::ReleaseBufferForRaster(
326 scoped_ptr<RasterBuffer> buffer) { 322 scoped_ptr<RasterBuffer> buffer) {
327 // Nothing to do here. RasterBufferImpl destructor cleans up after itself. 323 // Nothing to do here. RasterBufferImpl destructor cleans up after itself.
328 } 324 }
329 325
330 void PixelBufferRasterWorkerPool::OnRasterFinished(TaskSet task_set) { 326 void PixelBufferTileTaskWorkerPool::OnTaskSetFinished(TaskSet task_set) {
331 TRACE_EVENT2("cc", 327 TRACE_EVENT2("cc", "PixelBufferTileTaskWorkerPool::OnTaskSetFinished",
332 "PixelBufferRasterWorkerPool::OnRasterFinished", 328 "task_set", task_set,
333 "task_set",
334 task_set,
335 "should_notify_client_if_no_tasks_are_pending", 329 "should_notify_client_if_no_tasks_are_pending",
336 should_notify_client_if_no_tasks_are_pending_[task_set]); 330 should_notify_client_if_no_tasks_are_pending_[task_set]);
337 331
338 // There's no need to call CheckForCompletedRasterTasks() if the client has 332 // There's no need to call CheckForCompletedRasterTasks() if the client has
339 // already been notified. 333 // already been notified.
340 if (!should_notify_client_if_no_tasks_are_pending_[task_set]) 334 if (!should_notify_client_if_no_tasks_are_pending_[task_set])
341 return; 335 return;
342 raster_finished_tasks_pending_[task_set] = false; 336 task_set_finished_tasks_pending_[task_set] = false;
343 337
344 // This reduces latency between the time when all tasks required for 338 // This reduces latency between the time when all tasks required for
345 // activation have finished running and the time when the client is 339 // activation have finished running and the time when the client is
346 // notified. 340 // notified.
347 CheckForCompletedRasterTasks(); 341 CheckForCompletedRasterTasks();
348 } 342 }
349 343
350 void PixelBufferRasterWorkerPool::FlushUploads() { 344 void PixelBufferTileTaskWorkerPool::FlushUploads() {
351 if (!has_performed_uploads_since_last_flush_) 345 if (!has_performed_uploads_since_last_flush_)
352 return; 346 return;
353 347
354 context_provider_->ContextGL()->ShallowFlushCHROMIUM(); 348 context_provider_->ContextGL()->ShallowFlushCHROMIUM();
355 has_performed_uploads_since_last_flush_ = false; 349 has_performed_uploads_since_last_flush_ = false;
356 } 350 }
357 351
358 void PixelBufferRasterWorkerPool::CheckForCompletedUploads() { 352 void PixelBufferTileTaskWorkerPool::CheckForCompletedUploads() {
359 RasterTask::Vector tasks_with_completed_uploads; 353 RasterTask::Vector tasks_with_completed_uploads;
360 354
361 // First check if any have completed. 355 // First check if any have completed.
362 while (!raster_tasks_with_pending_upload_.empty()) { 356 while (!raster_tasks_with_pending_upload_.empty()) {
363 RasterTask* task = raster_tasks_with_pending_upload_.front().get(); 357 RasterTask* task = raster_tasks_with_pending_upload_.front().get();
364 DCHECK(std::find_if(raster_task_states_.begin(), 358 DCHECK(std::find_if(raster_task_states_.begin(),
365 raster_task_states_.end(), 359 raster_task_states_.end(),
366 RasterTaskState::TaskComparator(task)) != 360 RasterTaskState::TaskComparator(task)) !=
367 raster_task_states_.end()); 361 raster_task_states_.end());
368 DCHECK_EQ(RasterTaskState::UPLOADING, 362 DCHECK_EQ(RasterTaskState::UPLOADING,
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 task) == completed_raster_tasks_.end()); 441 task) == completed_raster_tasks_.end());
448 completed_raster_tasks_.push_back(task); 442 completed_raster_tasks_.push_back(task);
449 state.type = RasterTaskState::COMPLETED; 443 state.type = RasterTaskState::COMPLETED;
450 // Triggers if the current task belongs to a set that should be empty. 444 // Triggers if the current task belongs to a set that should be empty.
451 DCHECK((state.task_sets & ~NonEmptyTaskSetsFromTaskCounts(task_counts_)) 445 DCHECK((state.task_sets & ~NonEmptyTaskSetsFromTaskCounts(task_counts_))
452 .none()); 446 .none());
453 RemoveTaskSetsFromTaskCounts(task_counts_, state.task_sets); 447 RemoveTaskSetsFromTaskCounts(task_counts_, state.task_sets);
454 } 448 }
455 } 449 }
456 450
457 void PixelBufferRasterWorkerPool::CheckForCompletedRasterTasks() { 451 void PixelBufferTileTaskWorkerPool::CheckForCompletedRasterTasks() {
458 TRACE_EVENT0("cc", 452 TRACE_EVENT0("cc",
459 "PixelBufferRasterWorkerPool::CheckForCompletedRasterTasks"); 453 "PixelBufferTileTaskWorkerPool::CheckForCompletedRasterTasks");
460 454
461 // Since this function can be called directly, cancel any pending checks. 455 // Since this function can be called directly, cancel any pending checks.
462 check_for_completed_raster_task_notifier_.Cancel(); 456 check_for_completed_raster_task_notifier_.Cancel();
463 457
464 DCHECK(should_notify_client_if_no_tasks_are_pending_.any()); 458 DCHECK(should_notify_client_if_no_tasks_are_pending_.any());
465 459
466 CheckForCompletedRasterizerTasks(); 460 CheckForCompletedRasterizerTasks();
467 CheckForCompletedUploads(); 461 CheckForCompletedUploads();
468 FlushUploads(); 462 FlushUploads();
469 463
470 // Determine what client notifications to generate. 464 // Determine what client notifications to generate.
471 TaskSetCollection will_notify_client_that_no_tasks_are_pending = 465 TaskSetCollection will_notify_client_that_no_tasks_are_pending =
472 should_notify_client_if_no_tasks_are_pending_ & 466 should_notify_client_if_no_tasks_are_pending_ &
473 ~raster_finished_tasks_pending_ & ~PendingTasks(); 467 ~task_set_finished_tasks_pending_ & ~PendingTasks();
474 468
475 // Adjust the need to generate notifications before scheduling more tasks. 469 // Adjust the need to generate notifications before scheduling more tasks.
476 should_notify_client_if_no_tasks_are_pending_ &= 470 should_notify_client_if_no_tasks_are_pending_ &=
477 ~will_notify_client_that_no_tasks_are_pending; 471 ~will_notify_client_that_no_tasks_are_pending;
478 472
479 scheduled_raster_task_count_ = 0; 473 scheduled_raster_task_count_ = 0;
480 if (PendingRasterTaskCount()) 474 if (PendingRasterTaskCount())
481 ScheduleMoreTasks(); 475 ScheduleMoreTasks();
482 476
483 TRACE_EVENT_ASYNC_STEP_INTO1( 477 TRACE_EVENT_ASYNC_STEP_INTO1(
484 "cc", "ScheduledTasks", this, StateName(), "state", StateAsValue()); 478 "cc", "ScheduledTasks", this, StateName(), "state", StateAsValue());
485 479
486 // Schedule another check for completed raster tasks while there are 480 // Schedule another check for completed raster tasks while there are
487 // pending raster tasks or pending uploads. 481 // pending raster tasks or pending uploads.
488 if (PendingTasks().any()) 482 if (PendingTasks().any())
489 check_for_completed_raster_task_notifier_.Schedule(); 483 check_for_completed_raster_task_notifier_.Schedule();
490 484
491 if (should_notify_client_if_no_tasks_are_pending_.none()) 485 if (should_notify_client_if_no_tasks_are_pending_.none())
492 TRACE_EVENT_ASYNC_END0("cc", "ScheduledTasks", this); 486 TRACE_EVENT_ASYNC_END0("cc", "ScheduledTasks", this);
493 487
494 // Generate client notifications. 488 // Generate client notifications.
495 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) { 489 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
496 if (will_notify_client_that_no_tasks_are_pending[task_set]) { 490 if (will_notify_client_that_no_tasks_are_pending[task_set]) {
497 DCHECK(!PendingTasks()[task_set]); 491 DCHECK(!PendingTasks()[task_set]);
498 client_->DidFinishRunningTasks(task_set); 492 client_->DidFinishRunningTileTasks(task_set);
499 } 493 }
500 } 494 }
501 } 495 }
502 496
503 void PixelBufferRasterWorkerPool::ScheduleMoreTasks() { 497 void PixelBufferTileTaskWorkerPool::ScheduleMoreTasks() {
504 TRACE_EVENT0("cc", "PixelBufferRasterWorkerPool::ScheduleMoreTasks"); 498 TRACE_EVENT0("cc", "PixelBufferTileTaskWorkerPool::ScheduleMoreTasks");
505 499
506 RasterTaskVector tasks[kNumberOfTaskSets]; 500 RasterTaskVector tasks[kNumberOfTaskSets];
507 501
508 unsigned priority = kRasterTaskPriorityBase; 502 unsigned priority = kTileTaskPriorityBase;
509 503
510 graph_.Reset(); 504 graph_.Reset();
511 505
512 size_t bytes_pending_upload = bytes_pending_upload_; 506 size_t bytes_pending_upload = bytes_pending_upload_;
513 TaskSetCollection did_throttle_raster_tasks; 507 TaskSetCollection did_throttle_raster_tasks;
514 size_t scheduled_raster_task_count = 0; 508 size_t scheduled_raster_task_count = 0;
515 509
516 for (RasterTaskQueue::Item::Vector::const_iterator it = 510 for (TileTaskQueue::Item::Vector::const_iterator it =
517 raster_tasks_.items.begin(); 511 raster_tasks_.items.begin();
518 it != raster_tasks_.items.end(); 512 it != raster_tasks_.items.end(); ++it) {
519 ++it) { 513 const TileTaskQueue::Item& item = *it;
520 const RasterTaskQueue::Item& item = *it;
521 RasterTask* task = item.task; 514 RasterTask* task = item.task;
522 DCHECK(item.task_sets.any()); 515 DCHECK(item.task_sets.any());
523 516
524 // |raster_task_states_| contains the state of all tasks that we have not 517 // |raster_task_states_| contains the state of all tasks that we have not
525 // yet run reply callbacks for. 518 // yet run reply callbacks for.
526 RasterTaskState::Vector::iterator state_it = 519 RasterTaskState::Vector::iterator state_it =
527 std::find_if(raster_task_states_.begin(), 520 std::find_if(raster_task_states_.begin(),
528 raster_task_states_.end(), 521 raster_task_states_.end(),
529 RasterTaskState::TaskComparator(task)); 522 RasterTaskState::TaskComparator(task));
530 if (state_it == raster_task_states_.end()) 523 if (state_it == raster_task_states_.end())
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 567
575 InsertNodesForRasterTask(&graph_, task, task->dependencies(), priority++); 568 InsertNodesForRasterTask(&graph_, task, task->dependencies(), priority++);
576 569
577 ++scheduled_raster_task_count; 570 ++scheduled_raster_task_count;
578 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) { 571 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
579 if (item.task_sets[task_set]) 572 if (item.task_sets[task_set])
580 tasks[task_set].container().push_back(task); 573 tasks[task_set].container().push_back(task);
581 } 574 }
582 } 575 }
583 576
584 // Cancel existing OnRasterFinished callbacks. 577 // Cancel existing OnTaskSetFinished callbacks.
585 raster_finished_weak_ptr_factory_.InvalidateWeakPtrs(); 578 task_set_finished_weak_ptr_factory_.InvalidateWeakPtrs();
586 579
587 scoped_refptr<RasterizerTask> new_raster_finished_tasks[kNumberOfTaskSets]; 580 scoped_refptr<TileTask> new_task_set_finished_tasks[kNumberOfTaskSets];
588 size_t scheduled_task_counts[kNumberOfTaskSets] = {0}; 581 size_t scheduled_task_counts[kNumberOfTaskSets] = {0};
589 582
590 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) { 583 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
591 scheduled_task_counts[task_set] = tasks[task_set].container().size(); 584 scheduled_task_counts[task_set] = tasks[task_set].container().size();
592 DCHECK_LE(scheduled_task_counts[task_set], task_counts_[task_set]); 585 DCHECK_LE(scheduled_task_counts[task_set], task_counts_[task_set]);
593 // Schedule OnRasterFinished call for task set only when notification is 586 // Schedule OnTaskSetFinished call for task set only when notification is
594 // pending and throttling is not preventing all pending tasks in the set 587 // pending and throttling is not preventing all pending tasks in the set
595 // from being scheduled. 588 // from being scheduled.
596 if (!did_throttle_raster_tasks[task_set] && 589 if (!did_throttle_raster_tasks[task_set] &&
597 should_notify_client_if_no_tasks_are_pending_[task_set]) { 590 should_notify_client_if_no_tasks_are_pending_[task_set]) {
598 new_raster_finished_tasks[task_set] = CreateRasterFinishedTask( 591 new_task_set_finished_tasks[task_set] = CreateTaskSetFinishedTask(
599 task_runner_.get(), 592 task_runner_.get(),
600 base::Bind(&PixelBufferRasterWorkerPool::OnRasterFinished, 593 base::Bind(&PixelBufferTileTaskWorkerPool::OnTaskSetFinished,
601 raster_finished_weak_ptr_factory_.GetWeakPtr(), 594 task_set_finished_weak_ptr_factory_.GetWeakPtr(),
602 task_set)); 595 task_set));
603 raster_finished_tasks_pending_[task_set] = true; 596 task_set_finished_tasks_pending_[task_set] = true;
604 InsertNodeForTask(&graph_, 597 InsertNodeForTask(&graph_, new_task_set_finished_tasks[task_set].get(),
605 new_raster_finished_tasks[task_set].get(), 598 kTaskSetFinishedTaskPriority,
606 kRasterFinishedTaskPriority,
607 scheduled_task_counts[task_set]); 599 scheduled_task_counts[task_set]);
608 for (RasterTaskVector::ContainerType::const_iterator it = 600 for (RasterTaskVector::ContainerType::const_iterator it =
609 tasks[task_set].container().begin(); 601 tasks[task_set].container().begin();
610 it != tasks[task_set].container().end(); 602 it != tasks[task_set].container().end();
611 ++it) { 603 ++it) {
612 graph_.edges.push_back( 604 graph_.edges.push_back(
613 TaskGraph::Edge(*it, new_raster_finished_tasks[task_set].get())); 605 TaskGraph::Edge(*it, new_task_set_finished_tasks[task_set].get()));
614 } 606 }
615 } 607 }
616 } 608 }
617 609
618 DCHECK_LE(scheduled_raster_task_count, PendingRasterTaskCount()); 610 DCHECK_LE(scheduled_raster_task_count, PendingRasterTaskCount());
619 611
620 ScheduleTasksOnOriginThread(this, &graph_); 612 ScheduleTasksOnOriginThread(this, &graph_);
621 task_graph_runner_->ScheduleTasks(namespace_token_, &graph_); 613 task_graph_runner_->ScheduleTasks(namespace_token_, &graph_);
622 614
623 scheduled_raster_task_count_ = scheduled_raster_task_count; 615 scheduled_raster_task_count_ = scheduled_raster_task_count;
624 616
625 std::copy(new_raster_finished_tasks, 617 std::copy(new_task_set_finished_tasks,
626 new_raster_finished_tasks + kNumberOfTaskSets, 618 new_task_set_finished_tasks + kNumberOfTaskSets,
627 raster_finished_tasks_); 619 task_set_finished_tasks_);
628 } 620 }
629 621
630 unsigned PixelBufferRasterWorkerPool::PendingRasterTaskCount() const { 622 unsigned PixelBufferTileTaskWorkerPool::PendingRasterTaskCount() const {
631 unsigned num_completed_raster_tasks = 623 unsigned num_completed_raster_tasks =
632 raster_tasks_with_pending_upload_.size() + completed_raster_tasks_.size(); 624 raster_tasks_with_pending_upload_.size() + completed_raster_tasks_.size();
633 DCHECK_GE(raster_task_states_.size(), num_completed_raster_tasks); 625 DCHECK_GE(raster_task_states_.size(), num_completed_raster_tasks);
634 return raster_task_states_.size() - num_completed_raster_tasks; 626 return raster_task_states_.size() - num_completed_raster_tasks;
635 } 627 }
636 628
637 TaskSetCollection PixelBufferRasterWorkerPool::PendingTasks() const { 629 TaskSetCollection PixelBufferTileTaskWorkerPool::PendingTasks() const {
638 return NonEmptyTaskSetsFromTaskCounts(task_counts_); 630 return NonEmptyTaskSetsFromTaskCounts(task_counts_);
639 } 631 }
640 632
641 const char* PixelBufferRasterWorkerPool::StateName() const { 633 const char* PixelBufferTileTaskWorkerPool::StateName() const {
642 if (scheduled_raster_task_count_) 634 if (scheduled_raster_task_count_)
643 return "rasterizing"; 635 return "rasterizing";
644 if (PendingRasterTaskCount()) 636 if (PendingRasterTaskCount())
645 return "throttled"; 637 return "throttled";
646 if (!raster_tasks_with_pending_upload_.empty()) 638 if (!raster_tasks_with_pending_upload_.empty())
647 return "waiting_for_uploads"; 639 return "waiting_for_uploads";
648 640
649 return "finishing"; 641 return "finishing";
650 } 642 }
651 643
652 void PixelBufferRasterWorkerPool::CheckForCompletedRasterizerTasks() { 644 void PixelBufferTileTaskWorkerPool::CheckForCompletedRasterizerTasks() {
653 TRACE_EVENT0("cc", 645 TRACE_EVENT0(
654 "PixelBufferRasterWorkerPool::CheckForCompletedRasterizerTasks"); 646 "cc", "PixelBufferTileTaskWorkerPool::CheckForCompletedRasterizerTasks");
655 647
656 task_graph_runner_->CollectCompletedTasks(namespace_token_, 648 task_graph_runner_->CollectCompletedTasks(namespace_token_,
657 &completed_tasks_); 649 &completed_tasks_);
658 for (Task::Vector::const_iterator it = completed_tasks_.begin(); 650 for (Task::Vector::const_iterator it = completed_tasks_.begin();
659 it != completed_tasks_.end(); 651 it != completed_tasks_.end();
660 ++it) { 652 ++it) {
661 RasterizerTask* task = static_cast<RasterizerTask*>(it->get()); 653 TileTask* task = static_cast<TileTask*>(it->get());
662 654
663 RasterTask* raster_task = task->AsRasterTask(); 655 RasterTask* raster_task = task->AsRasterTask();
664 if (!raster_task) { 656 if (!raster_task) {
665 task->WillComplete(); 657 task->WillComplete();
666 task->CompleteOnOriginThread(this); 658 task->CompleteOnOriginThread(this);
667 task->DidComplete(); 659 task->DidComplete();
668 660
669 completed_image_decode_tasks_.push_back(task); 661 completed_image_decode_tasks_.push_back(task);
670 continue; 662 continue;
671 } 663 }
(...skipping 10 matching lines...) Expand all
682 resource_provider_->UnmapPixelBuffer(raster_task->resource()->id()); 674 resource_provider_->UnmapPixelBuffer(raster_task->resource()->id());
683 675
684 if (!raster_task->HasFinishedRunning()) { 676 if (!raster_task->HasFinishedRunning()) {
685 // When priorites change, a raster task can be canceled as a result of 677 // When priorites change, a raster task can be canceled as a result of
686 // no longer being of high enough priority to fit in our throttled 678 // no longer being of high enough priority to fit in our throttled
687 // raster task budget. The task has not yet completed in this case. 679 // raster task budget. The task has not yet completed in this case.
688 raster_task->WillComplete(); 680 raster_task->WillComplete();
689 raster_task->CompleteOnOriginThread(this); 681 raster_task->CompleteOnOriginThread(this);
690 raster_task->DidComplete(); 682 raster_task->DidComplete();
691 683
692 RasterTaskQueue::Item::Vector::const_iterator item_it = 684 TileTaskQueue::Item::Vector::const_iterator item_it =
693 std::find_if(raster_tasks_.items.begin(), 685 std::find_if(raster_tasks_.items.begin(), raster_tasks_.items.end(),
694 raster_tasks_.items.end(), 686 TileTaskQueue::Item::TaskComparator(raster_task));
695 RasterTaskQueue::Item::TaskComparator(raster_task));
696 if (item_it != raster_tasks_.items.end()) { 687 if (item_it != raster_tasks_.items.end()) {
697 state.type = RasterTaskState::UNSCHEDULED; 688 state.type = RasterTaskState::UNSCHEDULED;
698 continue; 689 continue;
699 } 690 }
700 691
701 DCHECK(std::find(completed_raster_tasks_.begin(), 692 DCHECK(std::find(completed_raster_tasks_.begin(),
702 completed_raster_tasks_.end(), 693 completed_raster_tasks_.end(),
703 raster_task) == completed_raster_tasks_.end()); 694 raster_task) == completed_raster_tasks_.end());
704 completed_raster_tasks_.push_back(raster_task); 695 completed_raster_tasks_.push_back(raster_task);
705 state.type = RasterTaskState::COMPLETED; 696 state.type = RasterTaskState::COMPLETED;
706 // Triggers if the current task belongs to a set that should be empty. 697 // Triggers if the current task belongs to a set that should be empty.
707 DCHECK((state.task_sets & ~NonEmptyTaskSetsFromTaskCounts(task_counts_)) 698 DCHECK((state.task_sets & ~NonEmptyTaskSetsFromTaskCounts(task_counts_))
708 .none()); 699 .none());
709 RemoveTaskSetsFromTaskCounts(task_counts_, state.task_sets); 700 RemoveTaskSetsFromTaskCounts(task_counts_, state.task_sets);
710 continue; 701 continue;
711 } 702 }
712 703
713 resource_provider_->BeginSetPixels(raster_task->resource()->id()); 704 resource_provider_->BeginSetPixels(raster_task->resource()->id());
714 has_performed_uploads_since_last_flush_ = true; 705 has_performed_uploads_since_last_flush_ = true;
715 706
716 bytes_pending_upload_ += raster_task->resource()->bytes(); 707 bytes_pending_upload_ += raster_task->resource()->bytes();
717 raster_tasks_with_pending_upload_.push_back(raster_task); 708 raster_tasks_with_pending_upload_.push_back(raster_task);
718 state.type = RasterTaskState::UPLOADING; 709 state.type = RasterTaskState::UPLOADING;
719 } 710 }
720 completed_tasks_.clear(); 711 completed_tasks_.clear();
721 } 712 }
722 713
723 scoped_refptr<base::debug::ConvertableToTraceFormat> 714 scoped_refptr<base::debug::ConvertableToTraceFormat>
724 PixelBufferRasterWorkerPool::StateAsValue() const { 715 PixelBufferTileTaskWorkerPool::StateAsValue() const {
725 scoped_refptr<base::debug::TracedValue> state = 716 scoped_refptr<base::debug::TracedValue> state =
726 new base::debug::TracedValue(); 717 new base::debug::TracedValue();
727 state->SetInteger("completed_count", completed_raster_tasks_.size()); 718 state->SetInteger("completed_count", completed_raster_tasks_.size());
728 state->BeginArray("pending_count"); 719 state->BeginArray("pending_count");
729 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) 720 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set)
730 state->AppendInteger(task_counts_[task_set]); 721 state->AppendInteger(task_counts_[task_set]);
731 state->EndArray(); 722 state->EndArray();
732 state->SetInteger("pending_upload_count", 723 state->SetInteger("pending_upload_count",
733 raster_tasks_with_pending_upload_.size()); 724 raster_tasks_with_pending_upload_.size());
734 state->BeginDictionary("throttle_state"); 725 state->BeginDictionary("throttle_state");
735 ThrottleStateAsValueInto(state.get()); 726 ThrottleStateAsValueInto(state.get());
736 state->EndDictionary(); 727 state->EndDictionary();
737 return state; 728 return state;
738 } 729 }
739 730
740 void PixelBufferRasterWorkerPool::ThrottleStateAsValueInto( 731 void PixelBufferTileTaskWorkerPool::ThrottleStateAsValueInto(
741 base::debug::TracedValue* throttle_state) const { 732 base::debug::TracedValue* throttle_state) const {
742 throttle_state->SetInteger("bytes_available_for_upload", 733 throttle_state->SetInteger("bytes_available_for_upload",
743 max_bytes_pending_upload_ - bytes_pending_upload_); 734 max_bytes_pending_upload_ - bytes_pending_upload_);
744 throttle_state->SetInteger("bytes_pending_upload", bytes_pending_upload_); 735 throttle_state->SetInteger("bytes_pending_upload", bytes_pending_upload_);
745 throttle_state->SetInteger("scheduled_raster_task_count", 736 throttle_state->SetInteger("scheduled_raster_task_count",
746 scheduled_raster_task_count_); 737 scheduled_raster_task_count_);
747 } 738 }
748 739
749 } // namespace cc 740 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698