cc: Renaming Rasterizer and RasterWorkerPool interfaces

cc: Renaming Rasterizer and RasterWorkerPool interfaces

We're planning to add a new Rasterizer interface to abstract some differences between GPU (Ganesh) and Software rasterization.

The old Rasterizer and RasterWorkerPool interfaces will be renamed to TileTaskRunner and TileTaskWorkerPool, to clarify they are not the actual rasterizers.

BUG=440188
Committed: https://crrev.com/a30e1eaf6130dab71bc4db5bfea72049203b1000
Cr-Commit-Position: refs/heads/master@{#307517}

[vmiura, 2014-12-06 02:13:52]

vmiura@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org, ernstm@chromium.org,
reveman@chromium.org, vmpstr@chromium.org

[vmiura, 2014-12-06 02:13:53]

FYI.  Renaming some of these files will cause some merging headaches if anyone
has code in flight.

[reveman, 2014-12-08 17:07:08]

Looks good.

Did you forget to add cc/resources/tile_task_runner.* files?

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool.h (right):

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool.h:32: static void SetNumRasterThreads(int
num_threads);
nit: SetNumThreads or SetNumWorkerThreads

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool.h:35: static int GetNumRasterThreads();
nit: GetNumThreads or GetNumWorkerThreads

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool_perftest.cc (right):

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_perftest.cc:429: return
std::string("_bitmap_raster_worker_pool");
should we update the modifier strings as part of this patch?

[vmiura, 2014-12-08 23:41:02]

Done, and updated the other files.  PTAL

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool.h (right):

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool.h:32: static void SetNumRasterThreads(int
num_threads);
On 2014/12/08 17:07:07, reveman wrote:
> nit: SetNumThreads or SetNumWorkerThreads

Done.

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool.h:35: static int GetNumRasterThreads();
On 2014/12/08 17:07:07, reveman wrote:
> nit: GetNumThreads or GetNumWorkerThreads

Done.

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
File cc/resources/raster_worker_pool_perftest.cc (right):

https://codereview.chromium.org/786583002/diff/1/cc/resources/raster_worker_p...
cc/resources/raster_worker_pool_perftest.cc:429: return
std::string("_bitmap_raster_worker_pool");
On 2014/12/08 17:07:07, reveman wrote:
> should we update the modifier strings as part of this patch?

Done.

[vmiura, 2014-12-09 00:36:56]

vmiura@chromium.org changed reviewers:
+ sievers@chromium.org

[vmiura, 2014-12-09 00:36:57]

sievers@chromium.org: Please review changes in 
  content/renderer/render_thread_impl.cc

[no sievers, 2014-12-09 00:41:35]

On 2014/12/09 00:36:57, vmiura wrote:
> mailto:sievers@chromium.org: Please review changes in 
>   content/renderer/render_thread_impl.cc

lgtm

[reveman, 2014-12-09 04:53:10]

lgtm, thanks for taking care of this rather painful rename

https://codereview.chromium.org/786583002/diff/40001/cc/resources/tile_task_r...
File cc/resources/tile_task_runner.h (right):

https://codereview.chromium.org/786583002/diff/40001/cc/resources/tile_task_r...
cc/resources/tile_task_runner.h:71: class CC_EXPORT RasterTask : public TileTask
{
This will be renamed to PrepareTask or something like that in a follow up,
right?

[vmiura, 2014-12-09 18:15:28]

https://codereview.chromium.org/786583002/diff/40001/cc/resources/tile_task_r...
File cc/resources/tile_task_runner.h (right):

https://codereview.chromium.org/786583002/diff/40001/cc/resources/tile_task_r...
cc/resources/tile_task_runner.h:71: class CC_EXPORT RasterTask : public TileTask
{
On 2014/12/09 04:53:09, reveman wrote:
> This will be renamed to PrepareTask or something like that in a follow up,
> right?

Yes I think so.

[vmiura, 2014-12-09 18:18:13]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-12-09 18:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786583002/40001

[commit-bot: I haz the power, 2014-12-09 19:23:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-09 19:25:05]

Patchset 3 (id:??) landed as
https://crrev.com/a30e1eaf6130dab71bc4db5bfea72049203b1000
Cr-Commit-Position: refs/heads/master@{#307517}

[jamesr, 2014-12-15 19:30:47]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-12-15 19:30:48]

A lot of the thread_times benchmarks started reporting 0 values after this
patch, e.g.:

https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fu...

[vmiura, 2014-12-15 19:35:39]

On 2014/12/15 19:30:48, jamesr wrote:
> A lot of the thread_times benchmarks started reporting 0 values after this
> patch, e.g.:
> 
>
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fu...

Ah, there's a dependency on "CompositorRasterWorker" thread name in the metric. 
I'll push a fix.

Thanks.