Linux: Add a script to generate a Precise dpkg admin dir for use with official builds on Trusty.

Linux: Add a script to generate a Precise dpkg admin dir for use with official builds on Trusty.

With the output dpkg admin dir, dpkg-shlibdeps can generate the right package dependencies.

[Lei Zhang, 2014-12-06 02:19:06]

thestig@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-12-08 10:12:16]

Thanks for the script, some comments.

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
File chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py
(right):

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:22:
PACKAGES = [
Can we de-duplicate the list of packages between this script and the
sysroot-generating script?

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:70: #
Hack for libpango1.0-0 vs libpango-1.0-0
Could you explain more why we need this hack? If possible I'd really like to
understand entire background behind it.

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:76: #
Hack for libpangocairo-1.0-0
Same here, I'm really surprised we'd need this.

Can we simplify things if we require Precise for running this script?

Or is compiling on Trusty a problem if we don't apply the hacks?

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:84: if
options.arch not in ['amd64', 'i386']:
At least argparse has built-in ways to validate that a value belongs to a set of
choices. Please consider using that.

https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:142:
dest_status_file_handle.close()
nit: Why not just "with open(...) as ..."?

[Sam Clegg, 2016-10-04 21:57:57]

On 2014/12/08 10:12:16, Paweł Hajdan Jr. wrote:
> Thanks for the script, some comments.
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> File chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py
> (right):
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:22:
> PACKAGES = [
> Can we de-duplicate the list of packages between this script and the
> sysroot-generating script?
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:70:
#
> Hack for libpango1.0-0 vs libpango-1.0-0
> Could you explain more why we need this hack? If possible I'd really like to
> understand entire background behind it.
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:76:
#
> Hack for libpangocairo-1.0-0
> Same here, I'm really surprised we'd need this.
> 
> Can we simplify things if we require Precise for running this script?
> 
> Or is compiling on Trusty a problem if we don't apply the hacks?
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:84:
if
> options.arch not in ['amd64', 'i386']:
> At least argparse has built-in ways to validate that a value belongs to a set
of
> choices. Please consider using that.
> 
>
https://codereview.chromium.org/786543004/diff/1/chrome/installer/linux/sysro...
> chrome/installer/linux/sysroot_scripts/generate_precise_dpkg_admin_dir.py:142:
> dest_status_file_handle.close()
> nit: Why not just "with open(...) as ..."?

How does one pass a custom admin dir to dpkg-shlibdeps?

Also, I'm not quite sure what we are trying to achieve here.   What is the
definition of "right package dependencies"?  Its it just that it matches some
pre-defined checked in file?   If you want to always get the same answer then
why not include the admin files in the existing sysroot and use that in call to
dpkg-shlibdeps?   We probably don't want to be using Precise at all here (since
our packages are being built for a baseline debian distro, not and ubuntu
distro, right?).

[Tom (Use chromium acct), 2016-10-04 23:40:42]

Description was changed from

==========
Linux: Add a script to generate a Precise dpkg admin dir for use with official
builds on Trusty.

With the output dpkg admin dir, dpkg-shlibdeps can generate the right package
dependencies.
==========

to

==========
Linux: Add a script to generate a Precise dpkg admin dir for use with official
builds on Trusty.

With the output dpkg admin dir, dpkg-shlibdeps can generate the right package
dependencies.
==========

[Tom (Use chromium acct), 2016-10-04 23:50:46]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-04 23:50:46]

I've created a continuation CL (not ready for review) at
https://codereview.chromium.org/2391573005/

I think creating a Precise admin dir should be OK for now just to unblock the
builder update effort.  

However, as a long term solution, we definitely want to generate the
/var/lib/dpkg dir in the sysroot creator scripts, since the scripts already pull
in everything we need, and the calculated deps should be based on whatever
sysroot we're using to build, not Precise.

[Lei Zhang, 2016-10-04 23:53:52]

On 2016/10/04 23:50:46, Tom Anderson wrote:
> I've created a continuation CL (not ready for review) at
> https://codereview.chromium.org/2391573005/
> 
> I think creating a Precise admin dir should be OK for now just to unblock the
> builder update effort.  
> 
> However, as a long term solution, we definitely want to generate the
> /var/lib/dpkg dir in the sysroot creator scripts, since the scripts already
pull
> in everything we need, and the calculated deps should be based on whatever
> sysroot we're using to build, not Precise.

It would be great if you can take this and run with it. I'll close it out.

[Tom (Use chromium acct), 2016-10-05 00:00:38]

On 2016/10/04 23:53:52, Lei Zhang wrote:
> On 2016/10/04 23:50:46, Tom Anderson wrote:
> > I've created a continuation CL (not ready for review) at
> > https://codereview.chromium.org/2391573005/
> > 
> > I think creating a Precise admin dir should be OK for now just to unblock
the
> > builder update effort.  
> > 
> > However, as a long term solution, we definitely want to generate the
> > /var/lib/dpkg dir in the sysroot creator scripts, since the scripts already
> pull
> > in everything we need, and the calculated deps should be based on whatever
> > sysroot we're using to build, not Precise.
> 
> It would be great if you can take this and run with it. I'll close it out.

Feel free to close