Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 786543002: libvpx.gyp: try again to fix Clang's -Wstring-conversion warning (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
Reviewers:
Tom Finegan
CC:
chromium-reviews, wwcv, fgalligan1
Visibility:
Public.

Description

libvpx.gyp: try again to fix Clang's -Wstring-conversion warning Using -Wno-conversion didn't work, since -Wstring-conversion was added afterwards. Using clang_warning_flags_unset should work better. BUG=431803 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M libvpx.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hans
I must have bungled this last time. This time I tested that it works with ...
6 years ago (2014-12-05 23:56:13 UTC) #2
jzern
On 2014/12/05 23:56:13, hans wrote: > I must have bungled this last time. > > ...
6 years ago (2014-12-06 00:25:29 UTC) #3
Tom Finegan
On 2014/12/06 00:25:29, jzern wrote: > On 2014/12/05 23:56:13, hans wrote: > > I must ...
6 years ago (2014-12-06 00:31:18 UTC) #4
hans
On 2014/12/06 00:31:18, Tom Finegan wrote: > lgtm > > Is there a gn change, ...
6 years ago (2014-12-06 00:34:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786543002/1
6 years ago (2014-12-06 00:35:06 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-06 00:36:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293280

Powered by Google App Engine
This is Rietveld 408576698