aw: Rendering test harness and end-to-end smoke test

android_webview/browser/test/rendering_test.h

Index: android_webview/browser/test/rendering_test.h
diff --git a/android_webview/browser/test/rendering_test.h b/android_webview/browser/test/rendering_test.h
index 31347ec5ec47d3316e359008789104cbe6a05e0c..d538aeab8e60a269854bf03e7d6793800544d0cd 100644
--- a/android_webview/browser/test/rendering_test.h
+++ b/android_webview/browser/test/rendering_test.h
@@ -6,7 +6,9 @@
 #define ANDROID_WEBVIEW_BROWSER_TEST_RENDERING_TEST_H_
 
 #include "android_webview/browser/browser_view_renderer_client.h"
+#include "android_webview/browser/test/fake_view_root_impl.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop_proxy.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
@@ -20,8 +22,11 @@ class TestSynchronousCompositor;
 namespace android_webview {
 
 class BrowserViewRenderer;
+class FakeViewRootImpl;
 
-class RenderingTest : public testing::Test, public BrowserViewRendererClient {
+class RenderingTest : public testing::Test,
+                      public BrowserViewRendererClient,
+                      public ViewRootHooks {
  public:
   // BrowserViewRendererClient overrides.
   bool RequestDrawGL(bool wait_for_completion) override;
@@ -38,27 +43,49 @@ class RenderingTest : public testing::Test, public BrowserViewRendererClient {
                          float max_page_scale_factor) override {}
   void DidOverscroll(gfx::Vector2d overscroll_delta) override {}
 
+  // ViewRootHooks overrides.
+  void WillOnDraw() override {}
+  void DidOnDraw() override {}
+  void WillSyncOnRT(SharedRendererState* functor) override {}
+  void DidSyncOnRT(SharedRendererState* functor) override {}
+  void WillProcessOnRT(SharedRendererState* functor) override {}
+  void DidProcessOnRT(SharedRendererState* functor) override {}
+  void WillDrawOnRT(SharedRendererState* functor) override {}
+  void DidDrawOnRT(SharedRendererState* functor) override {}
+
  protected:
   RenderingTest();
   ~RenderingTest() override;
 
-  void SetUpTestHarness();
-  void RunTest();
+  virtual void SetUpTestHarness();
+  virtual void StartTest();
 
-  virtual void StartTest() {}
+  void RunTest();
+  void InitializeCompositor();
+  void Attach();
+  void EndTest();
 
  private:

[hush (inactive), 2014/12/10 20:07:58]

you have multiple "protected" and "private" sections in this header file. Merge
them?

[boliu, 2014/12/10 21:30:32]

Style guide agrees with you:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_O...

I'll update it.

-  class ScopedInitializeCompositor;
-  void InitializeCompositor();
-  void TeardownCompositor();
+  void QuitMessageLoop();
 
   const scoped_ptr<base::MessageLoop> message_loop_;
-  scoped_ptr<content::TestSynchronousCompositor> compositor_;
+
+ protected:
+  scoped_refptr<base::MessageLoopProxy> ui_proxy_;
   scoped_ptr<BrowserViewRenderer> browser_view_renderer_;
+  scoped_ptr<content::TestSynchronousCompositor> compositor_;
+  scoped_ptr<FakeViewRootImpl> view_root_impl_;
 
+ private:
   DISALLOW_COPY_AND_ASSIGN(RenderingTest);
 };
 
+#define RENDERING_TEST_F(TEST_FIXTURE_NAME) \
+  TEST_F(TEST_FIXTURE_NAME, RunTest) {      \
+    RunTest();                              \
+  }                                         \
+  class NeedsSemicolon##TEST_FIXTURE_NAME {}\
+
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_TEST_RENDERING_TEST_H_