Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 786493003: Fix format string to handle pointers correctly. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix format string to handle pointers correctly. I chose to use %Id and a cast rather than %p in order to continue printing as decimal -- %p typically prints as hex. %Id is not portable, but this is Windows only code and %zd is not yet supported in VC++. BUG=427616 Committed: https://crrev.com/447ac5e77775c03acb6513e69c05ba1e6aceab47 Cr-Commit-Position: refs/heads/master@{#307156}

Patch Set 1 #

Patch Set 2 : Change from static_cast to reinterpret_cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sandbox/win/tests/validation_tests/suite.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
brucedawson
6 years ago (2014-12-05 20:05:33 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years ago (2014-12-05 21:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786493003/1
6 years ago (2014-12-05 21:50:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/35135) win_chromium_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/6714)
6 years ago (2014-12-05 22:11:25 UTC) #7
brucedawson
I just fixed a compile error which I introduced at the last minute in the ...
6 years ago (2014-12-05 22:28:08 UTC) #8
cpu_(ooo_6.6-7.5)
still lgtm
6 years ago (2014-12-06 03:37:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786493003/20001
6 years ago (2014-12-06 03:38:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-06 04:35:40 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-06 04:36:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/447ac5e77775c03acb6513e69c05ba1e6aceab47
Cr-Commit-Position: refs/heads/master@{#307156}

Powered by Google App Engine
This is Rietveld 408576698