Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 786473002: Android: Handle readback helper context init failure (Closed)

Created:
6 years ago by no sievers
Modified:
6 years ago
Reviewers:
danakj
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: Handle readback helper context init failure We should not attempt to create a GLHelper with a null GLES2Impl (it will crash), which is the case if context init failed. BUG=439363 NOTRY=True Committed: https://crrev.com/26e88baf416c3ed31c1f465d3ac42315bae22050 Cr-Commit-Position: refs/heads/master@{#307080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
no sievers
ptal
6 years ago (2014-12-05 19:50:31 UTC) #2
danakj
LGTM
6 years ago (2014-12-05 20:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786473002/1
6 years ago (2014-12-05 21:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786473002/1
6 years ago (2014-12-05 21:11:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 21:12:15 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-05 21:13:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26e88baf416c3ed31c1f465d3ac42315bae22050
Cr-Commit-Position: refs/heads/master@{#307080}

Powered by Google App Engine
This is Rietveld 408576698