Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786333004: [turbofan] Fix bunch of tests failing with --turbo-deoptimization. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bunch of tests failing with --turbo-deoptimization. R=bmeurer@chromium.org Committed: https://crrev.com/e9e772121b36697821dbfff61f36e0a68367f21c Cr-Commit-Position: refs/heads/master@{#26115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -40 lines) Patch
M src/compiler/linkage.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +45 lines, -35 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-16 17:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786333004/1
5 years, 11 months ago (2015-01-16 17:23:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 22:23:28 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9e772121b36697821dbfff61f36e0a68367f21c Cr-Commit-Position: refs/heads/master@{#26115}
5 years, 11 months ago (2015-01-16 22:23:47 UTC) #5
Michael Achenbach
5 years, 11 months ago (2015-01-17 13:36:15 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/804333005/ by machenbach@chromium.org.

The reason for reverting is: This changes layout test expectations. I ran a
bisect over the layout tests:

Bad:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1600

Good:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1599

If this is intentional please first land a CL with manualrebaseline test
expectations for the changed tests and then reland..

Powered by Google App Engine
This is Rietveld 408576698