Issue 78633002: Support InputMethodObserver in RemoteInputMethodWin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78633002: Support InputMethodObserver in RemoteInputMethodWin (Closed)

Created:
7 years, 1 month ago by yukawa

Modified:
7 years, 1 month ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support InputMethodObserver in RemoteInputMethodWin Starting with r236186, InputMethodBridge relies on InputMethodObserver::OnInputMethodDestroyed. BUG=164964 TEST=ui_unittest --gtest_filter=RemoteInputMethodWinTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236449

Patch Set 1 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+246 lines, -10 lines)			Patch
M	ui/base/ime/remote_input_method_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ime/remote_input_method_win.cc	View	12 chunks	+54 lines, -9 lines	0 comments	Download
M	ui/base/ime/remote_input_method_win_unittest.cc	View	4 chunks	+192 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/78633002/100001

7 years, 1 month ago (2013-11-21 05:20:33 UTC) #3

Message was sent while issue was closed.

Change committed as 236449

Expand Messages | Collapse Messages