Issue 786323004: [Android WebView] Generate the OSS licenses notice using jinja2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 786323004: [Android WebView] Generate the OSS licenses notice using jinja2 (Closed)

Created:
6 years ago by mnaganov (inactive)

Modified:
6 years ago

Reviewers:
Torne

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android WebView] Generate the OSS licenses notice using jinja2 Now the page looks similar to Android's "Open source licenses" page. Also fixed the script to use an absolute path to the Chromium's license file, to make it work downstream. BUG=443619 Committed: https://crrev.com/488ccc526af98c97013b8e71b289180110bb6d52 Cr-Commit-Position: refs/heads/master@{#309195}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -7 lines)			Patch
	A	android_webview/tools/licenses_notice.tmpl	View		1 chunk	+34 lines, -0 lines	0 comments	Download
	M	android_webview/tools/webview_licenses.py	View		3 chunks	+42 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786323004/1

6 years ago (2014-12-19 13:35:35 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-19 14:27:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/488ccc526af98c97013b8e71b289180110bb6d52
Cr-Commit-Position: refs/heads/master@{#309195}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages