Issue 786283002: Use the normal LayoutState constructor in RenderTableSection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 786283002: Use the normal LayoutState constructor in RenderTableSection. (Closed)

Created:
6 years ago by mstensho (USE GERRIT)

Modified:
6 years ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use the normal LayoutState constructor in RenderTableSection. Don't use the one reserved for the layout root. This was introduced by incorrect code conversion in https://codereview.chromium.org/335963002 Also resurrected an informative comment that got lost in that commit (and added some text on my own as well). R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186806

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	Source/core/rendering/LayoutState.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/LayoutState.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/RenderTableSection.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786283002/1

6 years ago (2014-12-09 20:29:31 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-09 20:31:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186806

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages