Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: ppapi/ppapi_nacl_test_common.gypi

Issue 786273008: Non-SFI mode: Enable PnaclTransitional Non-SFI browser tests on x86-64 bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/ppapi_nacl.gyp ('k') | ppapi/tests/create_nonsfi_test_nmf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/ppapi_nacl_test_common.gypi
diff --git a/ppapi/ppapi_nacl_test_common.gypi b/ppapi/ppapi_nacl_test_common.gypi
index ea6132723cf5a8f6b8c16996be49cacd3b01b26b..c91b439570c64407ecbfc2e23f6632204d4a65de 100644
--- a/ppapi/ppapi_nacl_test_common.gypi
+++ b/ppapi/ppapi_nacl_test_common.gypi
@@ -221,13 +221,29 @@
'--output=>(nmf_pnacl_newlib_nonsfi)',
],
'target_conditions': [
- ['enable_x86_32_nonsfi==1', {
+ ['enable_x86_32_nonsfi==1 and "<(target_arch)"=="ia32"', {
'inputs': ['>(out_pnacl_newlib_x86_32_nonsfi_nexe)'],
'action': [
'--program=>(out_pnacl_newlib_x86_32_nonsfi_nexe)',
'--arch=x86-32',
]
}],
+ ['enable_x86_32_nonsfi==1 and "<(target_arch)"=="x64"', {
+ 'inputs': ['>(out_pnacl_newlib_x86_32_nonsfi_nexe)'],
+ 'action': [
+ '--program=>(out_pnacl_newlib_x86_32_nonsfi_nexe)',
+ # This should be used only for nacl_helper_nonsfi test.
+ # In theory this should be x86-32. However, currently
+ # fallback logic to x86-32-nonsfi is not implemented,
+ # and, moreover, it would break the tests for current
+ # nacl_helper in Non-SFI mode on x64 Chrome.
+ # So, here we introduce the hack to use "x86-64" in order
+ # to take the benefit to run nacl_helper_nonsfi tests on
+ # x64 Chrome.
+ # TODO(hidehiko): Remove this hack.
+ '--arch=x86-64',
+ ]
+ }],
['enable_arm_nonsfi==1', {
'inputs': ['>(out_pnacl_newlib_arm_nonsfi_nexe)'],
'action': [
« no previous file with comments | « ppapi/ppapi_nacl.gyp ('k') | ppapi/tests/create_nonsfi_test_nmf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698