Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 786273008: Non-SFI mode: Enable PnaclTransitional Non-SFI browser tests on x86-64 bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 5 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 6 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 #endif 212 #endif
213 213
214 // Currently, translation from pexe to non-sfi nexe is supported only for 214 // Currently, translation from pexe to non-sfi nexe is supported only for
215 // x86-32 or ARM binary. 215 // x86-32 or ARM binary.
216 #if defined(OS_LINUX) && (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL)) 216 #if defined(OS_LINUX) && (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
217 # define MAYBE_PNACL_NONSFI(test_case) test_case 217 # define MAYBE_PNACL_NONSFI(test_case) test_case
218 #else 218 #else
219 # define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case 219 # define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
220 #endif 220 #endif
221 221
222 // Similar to MAYBE_TRANSITIONAL_NONSFI, this is available only on x86-32 or 222 // Similar to MAYBE_TRANSITIONAL_NONSFI, this is available only on x86-32,
223 // ARM. 223 // x86-64 or ARM linux.
224 // TODO(hidehiko,mazda): Merge this to the MAYBE_PNACL_NONSFI when it is 224 #if defined(OS_LINUX) && \
225 // supported on x86-64. 225 (defined(ARCH_CPU_X86) || defined(ARCH_CPU_X86_64) || \
Mark Seaborn 2015/01/17 00:50:47 Nit: You could use "defined(ARCH_CPU_X86_FAMILY)"
hidehiko 2015/01/28 15:04:16 Done.
226 #if defined(OS_LINUX) && (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL)) 226 defined(ARCH_CPU_ARMEL))
227 # define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) test_case 227 # define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) test_case
228 #else 228 #else
229 # define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) DISABLED_##test_case 229 # define MAYBE_PNACL_TRANSITIONAL_NONSFI(test_case) DISABLED_##test_case
230 #endif 230 #endif
231 231
232 232
233 #define NACL_BROWSER_TEST_F(suite, name, body) \ 233 #define NACL_BROWSER_TEST_F(suite, name, body) \
234 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \ 234 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
235 body \ 235 body \
236 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \ 236 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \
237 body \ 237 body \
238 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \ 238 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \
239 body 239 body
240 240
241 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_ 241 #endif // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698