Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 786273003: Avoid crash on some 64b ARM NEON platforms. (Closed)

Created:
6 years ago by tomhudson
Modified:
6 years ago
Reviewers:
djsollen
CC:
reviews_skia.org, Ben Murdoch, kevin.petit, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Avoid crash on some 64b ARM NEON platforms. The compiler may choose to use x30 for a local loop counter; ensure it's saved. Patch from kevin.petit@arm.com, verified by benm@google.com. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/414867c00463e1405ce2234cf7591b1788d20b9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
djsollen
lgtm
6 years ago (2014-12-09 14:59:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786273003/1
6 years ago (2014-12-09 15:01:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/414867c00463e1405ce2234cf7591b1788d20b9f
6 years ago (2014-12-09 15:09:13 UTC) #4
Tom Hudson
Heather, we'll want to merge this to M40; Mike says Eric & Ravi know how?
6 years ago (2014-12-09 15:11:18 UTC) #6
borenet
On 2014/12/09 15:11:18, Tom Hudson wrote: > Heather, we'll want to merge this to M40; ...
6 years ago (2014-12-09 21:02:22 UTC) #7
hcm
6 years ago (2014-12-09 21:27:34 UTC) #8
Message was sent while issue was closed.
On 2014/12/09 21:02:22, borenet wrote:
> On 2014/12/09 15:11:18, Tom Hudson wrote:
> > Heather, we'll want to merge this to M40; Mike says Eric & Ravi know how?
> 
> We don't have an automated process for this, so it'd just be the regular git
> way, something like:
> $ git checkout chrome/m40
> $ git cherry-pick 414867c00463e1405ce2234cf7591b1788d20b9f
> $ git push

Yes, there is an outdated page on our site that I'm in process of moving and
updating, Eric's instructions are right.  The other thing is the merge process
in Chrome to let them know its incoming, documented here:
https://sites.google.com/a/google.com/skia/chrome-merge-process

Powered by Google App Engine
This is Rietveld 408576698