Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786243002: Add DumpAccessibilityTree tests (17 of 20) ARIA Role: main, radio ARIA state/property: aria-multise… (Closed)

Created:
6 years ago by ramya.v
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (17 of 20) ARIA Role: main, radio ARIA state/property: aria-multiselectable HTML Tags: dd, script, input with a suggestions source element BUG=170589, 170588 Committed: https://crrev.com/4893b519c849b1f548f6fb66e53c729d3d9484f8 Cr-Commit-Position: refs/heads/master@{#307513}

Patch Set 1 #

Patch Set 2 : Uploading expectation files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 6 chunks +27 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-main.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/aria-main-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/aria-main-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-main-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-multiselectable.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-multiselectable-expected-android.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-multiselectable-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-multiselectable-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-radio.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/test/data/accessibility/aria-radio-expected-android.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/accessibility/aria-radio-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-radio-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/dd.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/dd-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/dd-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/dd-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/input-suggestions-source-element.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-suggestions-source-element-expected-android.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/input-suggestions-source-element-expected-mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/input-suggestions-source-element-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/script.html View 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/accessibility/script-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/script-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/script-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
6 years ago (2014-12-09 11:09:24 UTC) #2
dmazzoni
lgtm
6 years ago (2014-12-09 17:30:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786243002/20001
6 years ago (2014-12-09 17:30:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-09 18:59:31 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 19:00:43 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4893b519c849b1f548f6fb66e53c729d3d9484f8
Cr-Commit-Position: refs/heads/master@{#307513}

Powered by Google App Engine
This is Rietveld 408576698