Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7170)

Unified Diff: chromecast/base/metrics/cast_metrics_helper.h

Issue 786233003: Add UpdateCurrentAppInfo() interface to record info about current app, including (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/metrics/cast_metrics_helper.h
diff --git a/chromecast/base/metrics/cast_metrics_helper.h b/chromecast/base/metrics/cast_metrics_helper.h
index 9bacdcbe4b8a00e5c933e2337aed780879f63438..fb22ff8c6af1c65fe09b13241798f7f19dce54a7 100644
--- a/chromecast/base/metrics/cast_metrics_helper.h
+++ b/chromecast/base/metrics/cast_metrics_helper.h
@@ -45,6 +45,16 @@ class CastMetricsHelper {
int num_buckets) = 0;
};
+ // Decodes action_name/app_id/session_id/sdk_version from metrics name.
+ // Return false if the metrics name is not generated from
+ // EncodeAppInfoIntoMetricsName() with correct format.
+ static bool DecodeAppInfoFromMetricsName(
+ const std::string& metrics_name,
+ std::string* action_name,
+ std::string* app_id,
+ std::string* session_id,
+ std::string* sdk_version);
+
static CastMetricsHelper* GetInstance();
explicit CastMetricsHelper(
@@ -53,6 +63,10 @@ class CastMetricsHelper {
// This function stores the name and startup time of the active application.
virtual void TagAppStart(const std::string& app_name);
+ // This function updates the info for current active application.
+ virtual void UpdateCurrentAppInfo(const std::string& app_id,
+ const std::string& session_id,
+ const std::string& sdk_version);
// Logs UMA record for media play/pause user actions.
virtual void LogMediaPlay();
@@ -101,6 +115,12 @@ class CastMetricsHelper {
CastMetricsHelper();
private:
+ static std::string EncodeAppInfoIntoMetricsName(
+ const std::string& action_name,
+ const std::string& app_id,
+ const std::string& session_id,
+ const std::string& sdk_version);
+
void LogEnumerationHistogramEvent(const std::string& name,
int value, int num_buckets);
void LogTimeHistogramEvent(const std::string& name,
@@ -118,6 +138,9 @@ class CastMetricsHelper {
// Currently running app name. Used to construct histogram name.
std::string app_name_;
+ std::string app_id_;
+ std::string session_id_;
+ std::string sdk_version_;
// Whether a new app start time has been stored but not recorded.
// After the startup time has been used to generate an UMA event,
« no previous file with comments | « no previous file | chromecast/base/metrics/cast_metrics_helper.cc » ('j') | chromecast/base/metrics/cast_metrics_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698