Add UpdateCurrentAppInfo() interface to record info about current app, including

chromecast/base/metrics/cast_metrics_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/user_metrics.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
 #include "chromecast/base/metrics/cast_histograms.h"
 #include "chromecast/base/metrics/grouped_histogram.h"
 
 namespace chromecast {
 namespace metrics {
 
 // A useful macro to make sure current member function runs on the valid thread.
 #define MAKE_SURE_THREAD(callback, ...)                    \
   if (!message_loop_proxy_->BelongsToCurrentThread()) {    \
     message_loop_proxy_->PostTask(FROM_HERE, base::Bind(   \
         &CastMetricsHelper::callback,                      \
         base::Unretained(this), ##__VA_ARGS__));           \
     return;                                                \
   }
 
 namespace {
 
 CastMetricsHelper* g_instance = NULL;
 
 // Displayed frames are logged in frames per second (but sampling can be over
 // a longer period of time, e.g. 5 seconds).
 const int kDisplayedFramesPerSecondPeriod = 1000000;
 
 // Sample every 5 seconds, represented in microseconds.
 const int kNominalVideoSamplePeriod = 5000000;
 
+const char kMetricsNameAppInfoDelimiter = '#';
+
 }  // namespace
 
+// static
+
+// NOTE(gfhuang): This is a hacky way to encode/decode app infos into a
+// string. Mainly because it's hard to add another metrics serialization type
+// into components/metrics/serialization/.
+// static
+bool CastMetricsHelper::DecodeAppInfoFromMetricsName(
+    const std::string& metrics_name,
+    std::string* action_name,
+    std::string* app_id,
+    std::string* session_id,
+    std::string* sdk_version) {

[byungchul, 2014/12/11 18:35:49]

DCHECK()'s for pointers.

[gfhuang, 2014/12/11 19:20:26]

Done.

+  if (metrics_name.find(kMetricsNameAppInfoDelimiter) == std::string::npos) {
+    return false;
+  }

[byungchul, 2014/12/11 18:35:49]

remove {}

[gfhuang, 2014/12/11 19:20:26]

Done.

+  std::vector<std::string> tokens;
+  base::SplitString(metrics_name, kMetricsNameAppInfoDelimiter, &tokens);
+  DCHECK_EQ(tokens.size(), 4u);

[lcwu1, 2014/12/11 18:41:57]

If the number of the tokens is not 4, which means the metrics_name was probably
not encoded by EncodeAppInfoIntoMetricsName, then shouldn't you return false
here based on your comment in the header file?

[gfhuang, 2014/12/11 19:20:26]

If the metrics name has magic char '#', but tokens size if not 4, which means I
screw something up.
so I put DCHECK here to make sure I don't do something silly in the future, such
as use the magic char in normal metric.

+  // The order of tokens should match EncodeAppInfoIntoMetricsName().
+  *action_name = tokens[0];
+  *app_id = tokens[1];
+  *session_id = tokens[2];
+  *sdk_version = tokens[3];
+  return true;
+}
+
+// static
+std::string CastMetricsHelper::EncodeAppInfoIntoMetricsName(
+    const std::string& action_name,
+    const std::string& app_id,
+    const std::string& session_id,
+    const std::string& sdk_version) {
+  std::vector<std::string> parts;
+  parts.push_back(action_name);
+  parts.push_back(app_id);
+  parts.push_back(session_id);
+  parts.push_back(sdk_version);
+  return JoinString(parts, kMetricsNameAppInfoDelimiter);
+}
+
+// static
 CastMetricsHelper* CastMetricsHelper::GetInstance() {
   DCHECK(g_instance);
   return g_instance;
 }
 
 CastMetricsHelper::CastMetricsHelper(
     scoped_refptr<base::MessageLoopProxy> message_loop_proxy)
     : message_loop_proxy_(message_loop_proxy),
       metrics_sink_(NULL),
       record_action_callback_(base::Bind(&base::RecordComputedAction)) {
@@ skipping 13 matching lines @@
   g_instance = NULL;
 }
 
 void CastMetricsHelper::TagAppStart(const std::string& arg_app_name) {
   MAKE_SURE_THREAD(TagAppStart, arg_app_name);
   app_name_ = arg_app_name;
   app_start_time_ = base::TimeTicks::Now();
   new_startup_time_ = true;
 
   TagAppStartForGroupedHistograms(app_name_);
+  // Clear app info
+  UpdateCurrentAppInfo("", "", "");
+}
+
+void CastMetricsHelper::UpdateCurrentAppInfo(const std::string& app_id,
+                                             const std::string& session_id,
+                                             const std::string& sdk_version) {
+  MAKE_SURE_THREAD(UpdateCurrentAppInfo, app_id, session_id, sdk_version);
+  app_id_ = app_id;
+  session_id_ = session_id;
+  sdk_version_ = sdk_version;
 }
 
 void CastMetricsHelper::LogMediaPlay() {
-  RecordSimpleAction(GetMetricsNameWithAppName("MediaPlay", ""));
+  MAKE_SURE_THREAD(LogMediaPlay);
+  RecordSimpleAction(EncodeAppInfoIntoMetricsName(
+      "MediaPlay", app_id_, session_id_, sdk_version_));
 }
 
 void CastMetricsHelper::LogMediaPause() {
-  RecordSimpleAction(GetMetricsNameWithAppName("MediaPause", ""));
+  MAKE_SURE_THREAD(LogMediaPause);
+  RecordSimpleAction(EncodeAppInfoIntoMetricsName(
+      "MediaPause", app_id_, session_id_, sdk_version_));
 }
 
 void CastMetricsHelper::LogTimeToDisplayVideo() {
   if (!new_startup_time_) {  // For faster check.
     return;
   }
   MAKE_SURE_THREAD(LogTimeToDisplayVideo);
   new_startup_time_ = false;
   base::TimeDelta launch_time = base::TimeTicks::Now() - app_start_time_;
   const std::string uma_name(GetMetricsNameWithAppName("Startup",
@@ skipping 148 matching lines @@
     const base::TimeDelta& value) {
   // Follow UMA_HISTOGRAM_MEDIUM_TIMES definition.
   LogTimeHistogramEvent(name, value,
                         base::TimeDelta::FromMilliseconds(10),
                         base::TimeDelta::FromMinutes(3),
                         50);
 }
 
 }  // namespace metrics
 }  // namespace chromecast