Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: build/toolchain.gypi

Issue 786203003: Really enable DEBUG code on android unless full debug is specified (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 ['OS=="android"', { 1035 ['OS=="android"', {
1036 'variables': { 1036 'variables': {
1037 'android_full_debug%': 1, 1037 'android_full_debug%': 1,
1038 }, 1038 },
1039 'conditions': [ 1039 'conditions': [
1040 ['android_full_debug==0', { 1040 ['android_full_debug==0', {
1041 # Disable full debug if we want a faster v8 in a debug build. 1041 # Disable full debug if we want a faster v8 in a debug build.
1042 # TODO(2304): pass DISABLE_DEBUG_ASSERT instead of hiding DEBUG. 1042 # TODO(2304): pass DISABLE_DEBUG_ASSERT instead of hiding DEBUG.
1043 'defines!': [ 1043 'defines!': [
1044 'DEBUG', 1044 'DEBUG',
1045 'ENABLE_SLOW_DCHECKS',
1045 ], 1046 ],
1046 }], 1047 }],
1047 ], 1048 ],
1048 }], 1049 }],
1049 ], 1050 ],
1050 }, # DebugBaseCommon 1051 }, # DebugBaseCommon
1051 'Debug': { 1052 'Debug': {
1052 'inherit_from': ['DebugBaseCommon'], 1053 'inherit_from': ['DebugBaseCommon'],
1053 'conditions': [ 1054 'conditions': [
1054 ['v8_optimized_debug==0', { 1055 ['v8_optimized_debug==0', {
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 'OptimizeReferences': '2', 1128 'OptimizeReferences': '2',
1128 'EnableCOMDATFolding': '2', 1129 'EnableCOMDATFolding': '2',
1129 }, 1130 },
1130 }, 1131 },
1131 }], # OS=="win" 1132 }], # OS=="win"
1132 ], # conditions 1133 ], # conditions
1133 }, # Release 1134 }, # Release
1134 }, # configurations 1135 }, # configurations
1135 }, # target_defaults 1136 }, # target_defaults
1136 } 1137 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698