Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 7862013: Merge 94840 - Crashes in WebCore::ApplyStyleCommand.doApply() (Closed)

Created:
9 years, 1 month ago by sullivan
Modified:
9 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94840 - Crashes in WebCore::ApplyStyleCommand.doApply() https://bugs.webkit.org/show_bug.cgi?id=67765 Patch by Shinya Kawanaka <shinyak@google.com>; on 2011-09-09 Reviewed by Ryosuke Niwa. WebCore::enclosingBlock may return null, but ApplyStyleCommand::applyBlockStyle did not check it. This patch make it to be checked. Source/WebCore: Test: editing/style/remove-format-without-enclosing-block.html * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Added null check. LayoutTests: * editing/style/remove-format-without-enclosing-block-expected.txt: Added. * editing/style/remove-format-without-enclosing-block.html: Added. TBR=sullivan@chromium.org BUG=95550 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A + LayoutTests/editing/style/remove-format-without-enclosing-block.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/style/remove-format-without-enclosing-block-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/ApplyStyleCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sullivan
9 years, 1 month ago (2011-09-09 22:59:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698