Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786193004: PropertyType is divided into PropertyKind and PropertyStoreMode. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

PropertyType is divided into PropertyKind and PropertyStoreMode.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -31 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/property-details.h View 1 4 chunks +26 lines, -2 lines 0 comments Download
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 13 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
6 years ago (2014-12-12 12:10:45 UTC) #2
Jakob Kummerow
LGTM. An exciting first step! https://codereview.chromium.org/786193004/diff/1/src/property-details.h File src/property-details.h (right): https://codereview.chromium.org/786193004/diff/1/src/property-details.h#newcode51 src/property-details.h:51: enum PropertyStoreMode { IN_OBJECT ...
6 years ago (2014-12-12 12:19:04 UTC) #3
Igor Sheludko
https://codereview.chromium.org/786193004/diff/1/src/property-details.h File src/property-details.h (right): https://codereview.chromium.org/786193004/diff/1/src/property-details.h#newcode51 src/property-details.h:51: enum PropertyStoreMode { IN_OBJECT = 0, IN_DESCRIPTOR = 1 ...
6 years ago (2014-12-12 12:38:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786193004/20001
6 years ago (2014-12-12 12:38:50 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 13:06:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698