Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/sync/test/integration/migration_errors_test.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/migration_errors_test.cc
diff --git a/chrome/browser/sync/test/integration/migration_errors_test.cc b/chrome/browser/sync/test/integration/migration_errors_test.cc
index 868e5738e625ac5346dedc2c19195e3b35110183..81e7647eef2be3188ed0550aba7323a0b4da7905 100644
--- a/chrome/browser/sync/test/integration/migration_errors_test.cc
+++ b/chrome/browser/sync/test/integration/migration_errors_test.cc
@@ -177,7 +177,13 @@ class MigrationTest : public SyncTest {
}
// Phase 3: Wait for all clients to catch up.
- AwaitQuiescence();
+ //
+ // AwaitQuiescence() will not succeed when notifications are enabled. We
+ // can safely avoid calling it because we know that, in the single client
+ // case, there is no one else to wait for.
+ if (!do_test_without_notifications) {
+ AwaitQuiescence();
+ }
// Re-enable notifications if we disabled it.
if (do_test_without_notifications) {
« no previous file with comments | « chrome/browser/sync/sync_ui_util.cc ('k') | chrome/browser/sync/test/integration/performance/sync_timing_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698