Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/browser/sync/profile_sync_service_harness.h" 6 #include "chrome/browser/sync/profile_sync_service_harness.h"
7 #include "chrome/browser/translate/translate_prefs.h" 7 #include "chrome/browser/translate/translate_prefs.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 8 #include "chrome/browser/sync/test/integration/sync_test.h"
9 #include "chrome/browser/sync/test/integration/preferences_helper.h" 9 #include "chrome/browser/sync/test/integration/preferences_helper.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 113 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
114 DisableVerifier(); 114 DisableVerifier();
115 115
116 ASSERT_TRUE(BooleanPrefMatches(prefs::kSyncPreferences)); 116 ASSERT_TRUE(BooleanPrefMatches(prefs::kSyncPreferences));
117 ASSERT_TRUE(BooleanPrefMatches( 117 ASSERT_TRUE(BooleanPrefMatches(
118 prefs::kPasswordManagerEnabled)); 118 prefs::kPasswordManagerEnabled));
119 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 119 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
120 120
121 GetClient(1)->DisableSyncForAllDatatypes(); 121 GetClient(1)->DisableSyncForAllDatatypes();
122 ChangeBooleanPref(0, prefs::kPasswordManagerEnabled); 122 ChangeBooleanPref(0, prefs::kPasswordManagerEnabled);
123 ASSERT_TRUE(GetClient(0)->AwaitSyncCycleCompletion("Changed a preference.")); 123 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion("Changed a preference."));
124 ASSERT_FALSE(BooleanPrefMatches( 124 ASSERT_FALSE(BooleanPrefMatches(
125 prefs::kPasswordManagerEnabled)); 125 prefs::kPasswordManagerEnabled));
126 126
127 ChangeBooleanPref(1, prefs::kShowHomeButton); 127 ChangeBooleanPref(1, prefs::kShowHomeButton);
128 ASSERT_FALSE(BooleanPrefMatches(prefs::kShowHomeButton)); 128 ASSERT_FALSE(BooleanPrefMatches(prefs::kShowHomeButton));
129 129
130 GetClient(1)->EnableSyncForAllDatatypes(); 130 GetClient(1)->EnableSyncForAllDatatypes();
131 ASSERT_TRUE(AwaitQuiescence()); 131 ASSERT_TRUE(AwaitQuiescence());
132 ASSERT_TRUE(BooleanPrefMatches( 132 ASSERT_TRUE(BooleanPrefMatches(
133 prefs::kPasswordManagerEnabled)); 133 prefs::kPasswordManagerEnabled));
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 ASSERT_TRUE(IsEncrypted(0, syncable::PREFERENCES)); 681 ASSERT_TRUE(IsEncrypted(0, syncable::PREFERENCES));
682 ASSERT_TRUE(IsEncrypted(1, syncable::PREFERENCES)); 682 ASSERT_TRUE(IsEncrypted(1, syncable::PREFERENCES));
683 ASSERT_TRUE(BooleanPrefMatches( 683 ASSERT_TRUE(BooleanPrefMatches(
684 prefs::kHomePageIsNewTabPage)); 684 prefs::kHomePageIsNewTabPage));
685 685
686 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 686 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
687 ChangeBooleanPref(0, prefs::kShowHomeButton); 687 ChangeBooleanPref(0, prefs::kShowHomeButton);
688 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 688 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
689 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton)); 689 ASSERT_TRUE(BooleanPrefMatches(prefs::kShowHomeButton));
690 } 690 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698