Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/rand_util.h" 5 #include "base/rand_util.h"
6 #include "chrome/browser/profiles/profile.h" 6 #include "chrome/browser/profiles/profile.h"
7 #include "chrome/browser/sync/profile_sync_service_harness.h" 7 #include "chrome/browser/sync/profile_sync_service_harness.h"
8 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 8 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
9 #include "chrome/browser/sync/test/integration/sync_test.h" 9 #include "chrome/browser/sync/test/integration/sync_test.h"
10 10
(...skipping 1499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1510 ASSERT_TRUE(AllModelsMatch()); 1510 ASSERT_TRUE(AllModelsMatch());
1511 } 1511 }
1512 1512
1513 // TCM ID - 7343544. 1513 // TCM ID - 7343544.
1514 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) { 1514 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) {
1515 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 1515 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
1516 ASSERT_TRUE(AllModelsMatchVerifier()); 1516 ASSERT_TRUE(AllModelsMatchVerifier());
1517 1517
1518 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes()); 1518 ASSERT_TRUE(GetClient(1)->DisableSyncForAllDatatypes());
1519 ASSERT_TRUE(AddFolder(0, IndexedFolderName(0)) != NULL); 1519 ASSERT_TRUE(AddFolder(0, IndexedFolderName(0)) != NULL);
1520 ASSERT_TRUE(GetClient(0)->AwaitSyncCycleCompletion("Added a folder.")); 1520 ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion("Added a folder."));
1521 ASSERT_FALSE(AllModelsMatch()); 1521 ASSERT_FALSE(AllModelsMatch());
1522 1522
1523 ASSERT_TRUE(AddFolder(1, IndexedFolderName(1)) != NULL); 1523 ASSERT_TRUE(AddFolder(1, IndexedFolderName(1)) != NULL);
1524 ASSERT_FALSE(AllModelsMatch()); 1524 ASSERT_FALSE(AllModelsMatch());
1525 1525
1526 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes()); 1526 ASSERT_TRUE(GetClient(1)->EnableSyncForAllDatatypes());
1527 ASSERT_TRUE(AwaitQuiescence()); 1527 ASSERT_TRUE(AwaitQuiescence());
1528 ASSERT_TRUE(AllModelsMatch()); 1528 ASSERT_TRUE(AllModelsMatch());
1529 } 1529 }
1530 1530
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1749 1749
1750 ASSERT_TRUE(AddURL(0, IndexedURLTitle(1), GURL(IndexedURL(1))) != NULL); 1750 ASSERT_TRUE(AddURL(0, IndexedURLTitle(1), GURL(IndexedURL(1))) != NULL);
1751 ASSERT_TRUE(AddFolder(0, IndexedFolderName(0)) != NULL); 1751 ASSERT_TRUE(AddFolder(0, IndexedFolderName(0)) != NULL);
1752 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 1752 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
1753 ASSERT_TRUE(AllModelsMatchVerifier()); 1753 ASSERT_TRUE(AllModelsMatchVerifier());
1754 } 1754 }
1755 1755
1756 // TODO(zea): Add first time sync functionality testing. In particular, when 1756 // TODO(zea): Add first time sync functionality testing. In particular, when
1757 // there are encrypted types in first time sync we need to ensure we don't 1757 // there are encrypted types in first time sync we need to ensure we don't
1758 // duplicate bookmarks. 1758 // duplicate bookmarks.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698